Opened 4 months ago
Closed 3 months ago
#15302 closed defect (fixed)
AGS: Running unknown games fails with path error
Reported by: | tag2015 | Owned by: | antoniou79 |
---|---|---|---|
Priority: | normal | Component: | Engine: AGS |
Version: | Keywords: | ||
Cc: | Game: |
Description (last modified by )
After the merge of PR 5829, it is no longer possible to start unknown games that have been added using the fallback detection.
Steps to reproduce:
- Find a game that is not in the detection tables, such as this testgame
- Add the game using the launcher, choose "add anyway"
- Try to run the game. It'll fail while attempting to load the resources reporting a garbage gamepath.
It should be noted, that the issue only happens for completely unknown games, variants (i.e. games that are in the detection tables, but with different checksum/size) can be run normally.
Change History (4)
comment:1 by , 4 months ago
comment:2 by , 4 months ago
Description: | modified (diff) |
---|
comment:3 by , 4 months ago
Update: I can reproduce the problem using builbot daily builds for windows, but it works properly with my msys2 build using configure options
--disable-all-engines --enable-optimizations --enable-detection-full --enable-engine=ags,director
comment:4 by , 3 months ago
Owner: | set to |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Fixed with this PR:
https://github.com/scummvm/scummvm/pull/6061
Note:
See TracTickets
for help on using tickets.
After some quick debugging, it seems that the problem occurs when
identifyGame
callsfallbackDetect
.The
fallbackDetectedGame
struct should be initialized afterfallbackDetect
returns, but instead thefilesDescriptions
array contains garbage.