Opened 3 months ago
Closed 6 days ago
#15341 closed defect (fixed)
GOB2: footsteps sound issues
Reported by: | DisizDream | Owned by: | bluegr |
---|---|---|---|
Priority: | high | Component: | Engine: Gob |
Version: | Keywords: | ||
Cc: | DisizDream | Game: | Gobliins 2 |
Description
ScummVM version:
ScummVM 2.8.1 (Mar 16 2024 13:01:03)
Bug details:
Hi, I have noticed that the footsteps are not playing correctly in Gobliins 2. With the multilingual PC DOS CD version (CD v2.01, 24a6b32757752ccb1917ce92fd7c2a04) the footsteps can be heard but very rarely. If you walk from the far left to the far right of the screen, you will be lucky to hear up to 2 footsteps.
With the PC DOS Floppy version (b45b984ee8017efd6ea965b9becd4d66) you can't hear any footsteps at all.
When playing the same version in DOSBox, you can hear every footsteps in both the floppy and CD version.
I have tried very old version of ScummVM (0.12.0) to see if it was a regression, and it seems this bug was there since a long time.
Language of game: any
Version of game: PC DOS Floppy and PC DOS CD
Your OS: Windows 10 Home 10.0.19045 Build 19045
Change History (8)
comment:1 by , 3 months ago
comment:2 by , 2 months ago
Owner: | set to |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Fixed by Antonin-Carette-RedArtGames in commit: https://github.com/scummvm/scummvm/commit/64538394ecb2f8f06ea5041385c79e4d956befee
comment:3 by , 2 months ago
Resolution: | fixed |
---|---|
Status: | closed → new |
This is not fixed. Using latest master I can reproduce the issue.
AFAIK the recent PR addressed background music, not sound effects.
comment:4 by , 2 months ago
Hi,
Thanks @tag2015 for reopening the ticket.
My previous PR did not solve this issue, indeed.
So, I have a fix for the CD-Rom version, but not for the Floppy version yet.
I will continue to work on it and keep you updated.
I don't know if I can submit the fix for the CD-Rom now and update later for the Floppy, or if the community prefers to receive the full PR only.
comment:5 by , 7 days ago
If you have a fix for the CD version maybe you could open a PR, the next ScummVM release is approaching and it'd be nice to include it :)
comment:6 by , 7 days ago
Hi tag2015,
I have submitted it here: https://github.com/scummvm/scummvm/pull/6222
comment:8 by , 6 days ago
Owner: | changed from | to
---|---|
Resolution: | → fixed |
Status: | new → closed |
Hi,
The issue is maybe related to the fact that a delay can be NULL (0), in the function
void PCSpeaker::stop(int32 delay)
which can disable the stacked foot sound effect.
Maybe increasing the
delay
variable (likemax(1, delay)
) might solve the problem, I will check on my side.