HYPNO: Bad performance under Android in menu of Spider Man: Sinister Six

[lephilousophe]

With profiling, we can see that Hypno::HypnoEngine::changeCursor is called very often.
This one spends many time opening files (using Android SAF which is slow) and decoding the image.
The cursor should only be decoded when it actually needs to be changed.

[eriktorbjorn]

I've submitted a possible fix, but I have no way of testing it on Android: ​https://github.com/scummvm/scummvm/pull/6219

[eriktorbjorn]

Would be good to resolve this for the 2.9.0 release.

[Torbjörn Andersson <eriktorbjorn@…>]

In a5d3e075:

HYPNO: Cache Smacker cursors, hopefully improving performance (bug #15347)

At least in Spider Man: Sinister Six the cursor is constantly being
changed to the current cursor, and since that involves decoding a
Smacker file it is apparently quite slow on Android. Possibly on other
systems as well.

The cursor doesn't actually change, though - it is not animated - so by
remembering the previously decoded cursor we can cut down on unnecessary
file access.

[neuromancer]

This was tested on Linux desktop, but not in Android. Can someone confirm it works better there?

[lephilousophe]

Confirmed.