SCUMM: INDY3: atari st - no sound after modifying the resources for new translation

[gabberhead]

when u unpack the atari st version with scummrp, and right after that repack it again, without modifying anything, and when u adding the game to scummvm and start the game, there is no sound. u have to set under audio options "IBM PCjr-Emulator" and then u get the same sound, like with the original retail version, which is recognized by scummvm, because of the right md5 hash. perhaps there is a bug with the atari st and the fallback ega recognition, because with the ms-dos ega/vga, amiga and fm towns version, there is sound after u adding the game without changing anything in the audio option of the game.
i have testet it with the german version only and the newest daily build, but i think, the other versions with different languages are also affected.

and of course there is also no sound, when u modify the game, and also repack it.

[AndywinXp]

Hi, is the md5 different? If so, of course it's not going to work... Each single game entry is characterized by (among other things) the platform attribute. Based on this attribute, things like the video renderer and the audio driver are chosen.

This really doesn't look like a bug, it's rather intended behavior; if you want to support a complete mod in the future, then we might be able to add a new entry. By design we don't add or directly support arbitrarly modified versions, if anything, for security reason (arbitrary code execution, etc.)

Just do it manually until you finish your mod and then we can talk about it.

[gabberhead]

iam doing it manually. but this is the problem. when u add the game to scummvm, because of the md5 hash it will not recognized as german version. thats ok. but i can choose between 3 versions. ega, ega (no adlib) and one other as fallback. but when i choose ega and use german as language and atari st as platform, there is no sound. until i change in audio to "IBM PCjr-Emulator".

with my modified amiga, fm towns and dos ega/vga versions i add the same way. but when i add them to scummvm via fallback because of no right md5 hash, and when i start the game, there is sound right from the beginning. only with the modified atari st version, there is no sound with default standard audio.

[AndywinXp]

I see. Well as I said because of security reasons we can't add explicit and universal support to modified versions, unless they are complete mods (like, for example, the ultimate talkie versions of the first two Monkey Island). And because all the different SCUMM platforms have their own different driver selection heuristics, proper detection entries are necessary in order to avoid the need to modify settings like you have to do now.

I'm afraid I personally can't help you with that. But if you happen to produce a full fledged mod, we might be able to have a detection entry so that you don't have to perform additional operations.

I'll leave the ticket open for a while, maybe some other dev can chime in on this...

[gabberhead]

perhaps dwatteau can help. he knows me already :) i was in contact with him already, because of his scummtr latest version was not able to extract the german text, because of the germman letter "ß" which he fixed, and this with this fix, he fixed a 18 year old bug in scummvm.

[AndywinXp]

Oh you want to make a german uncensored version of the game? That seems like some thing we could really add to the detection once it's done. So if this won't be able to be resolved (because of the reasons stated above), once the mod is complete we will surely add it.

[gabberhead]

i made uncensored versions of the german amiga version and now for atari st version. i modified a little bit the already existing vga and ega uncensored versions from other ones, because there were some things missing for a full uncensored game. and i heavily modified the also existing german fm-towns also from another one, with new audio tracks for venice, room 45 with hitler on the stage in berlin and for the zeppelin piano room, because those 3 original music tracks are more then bad :)
they are all finished already. but they need more testing, more people too play and give feedback.
the only greater problem which i know is in the one problem with the map in the fmtowns version. from venice to schloss brunwald, whe map is shown correctly, but later in the game, for example from berlon to iskenderun, the swastika flag is in the middle a black circle and the german country names are in few place have little bit of black colors. i dont know where the problem is, because in the beginning it is working, and later not, but it always is uising the same file for the map.

[dwatteau]

Hi gabberhead,

The fallback code that's used when a game isn't in our detection tables is sometimes not very good. For example (if my memory serves me well), changing a single byte inside the 000.LFL of the VGA floppy release of Monkey1 makes ScummVM "think" that it's the EGA release, and then problems happen when trying to play that. testGame() in engines/scumm/detection_internal.h could be improved; that's somewhere in the lower part of my TODO list :)

I can't say whether that's the issue in your Indy3 Atari ST case, though. That could also be a bug in scummrp/scummtr that corrupts some resources or something. I've created an issue in the ScummTR project for that, but I'm not sure I will have time for this at the moment...

Anyway, improving this use-case has never been a high priority in ScummVM, yes. It's a bit unfortunate, though, because it does make working on fan-translations harder (unless you want to iterate with DOSBox or DREAMM until you're done with your translation…).

I'll see if how I could help, in some way. Maybe I can provide you a modified ScummVM that will "tolerate" a modified Indy3 Atari ST a bit more, that you could locally use, for as long as you're working on your translation -- that could be a quick'n'dirty change, then. If we want a cleaner approach for everybody, though, that would require more time and I'm not sure I'm going to have it for now…

[gabberhead]

thanx for the answer. the atari st version is finished as i can say. and normaly, it dont need any changes anymore. the other ones also not. inkl. the uncensoring of the german text. only, when something is not as it should be. but i played the vga and fmtowns from start till beginning, and i didnt see any problems. except of the map problem in the fmtowns version. in the vga version, with the same map file, there is no problem. and i dont know why. but this was already i problem, before i start to modifying it.

[dwatteau]

Replying to gabberhead:

the only greater problem which i know is in the one problem with the map in the fmtowns version. from venice to schloss brunwald, whe map is shown correctly, but later in the game, for example from berlon to iskenderun, the swastika flag is in the middle a black circle and the german country names are in few place have little bit of black colors. i dont know where the problem is, because in the beginning it is working, and later not, but it always is uising the same file for the map.

For this, I'd suggest coming over our Discord server (the link is at the top of the main scummvm.org page), it's just going to be easier to iterate there, with screenshots and so on. Of course, people reply when they want to, but I'm interested in having a look at that.

Also, it's much easier for us to review tickets which focus on a single problem at a time. Having too many topics mentioned in a single ticket means that things will get lost/forgotten, or that interest in fixing things will go down, because it becomes too hard to follow.

Thanks!

[gabberhead]

ok. i am now on discord. can u contact me? the we can discuss it there. gabberhead5838.