#15419 closed feature request (fixed)
AGI: option to disable "predictive input keyboard dialog popup"
| Reported by: | Taiyaki777 | Owned by: | antoniou79 |
|---|---|---|---|
| Priority: | normal | Component: | Engine: AGI |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
An option to disable the predictive input keyboard popups in AGI games would be useful for those of us on computers who don't need the feature. It can be somewhat immersion breaking in these classic games (such as early King's Quest titles) to have a cellphone style keyboard popup when accidentally clicking in the lower parts of the screen.
Change History (5)
comment:1 by , 4 weeks ago
comment:2 by , 4 weeks ago
I have opened a PR for this feature request here:
https://github.com/scummvm/scummvm/pull/6201
Some feedback is required.
I have kept it as default "true", but now the player can disable it from the UI. This affects only the behavior of showing the popup upon a left mouse click within the prompt line or a text input field.
This will not need to remove and re-add the game, but it will need to launch the game once and exit it before the new option shows up Game Options for the game.
comment:4 by , 4 weeks ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
This feature is now disabled by default. It can be enabled with a new game option.
These changes have been implemented in the following PR:
https://github.com/scummvm/scummvm/pull/6201
Thanks to @antoniou79 for his work on this.
Closing
I agree completely. In my opinion the predictive dialog should be optional and disabled by default on most if not all currently supported platforms.
When I started working on AGI this year, I was surprised that this feature is mandatory. I accidentally trip it all the time, because if you use a mouse then it's practically unavoidable in some games, and we enable mouse support by default. Presumably this happens to most users, so I was surprised there weren't tickets about this.
This isn't about the *quality* of the predictive dialog feature; it's just that it's not a good default for (at least) desktop builds and should be optional. It may even be completely outdated, I don't know. It hasn't been used in any other scummvm engines, and it predates smart phones: https://wiki.scummvm.org/index.php/AGI/Predictive_Dialog .
Altering what's configurable after the feature has shipped is tricky in scummvm because of existing config files, default values, and that new options we add to advanced detector entries don't appear when users upgrade. (They have to remove and re-add their game.) It's trickier here because I think platform is a consideration too. But I still think we should do something about this; it seemed wrong to me right away and this is the ticket I would have written as a user =)