ANDROID: LAN: Inability to create folder or upload files to external app storage in developer builds

[antoniou79]

I've tested with release build (2.8.1.1) which does not have this issue and recent daily developer build (2.9.0git) which has this issue. The test device is an Android 12 smartphone.

Steps to reproduce:

• Install a daily developer build (2.9.0git) and launch the "ScummVM (debug)" app
• Start a LAN server from launcher's Global Options -> LAN -> Run server
• Set its "/root/ Path" folder to the "ScummVM data (External)" (the shortcut for it is on the topmost level of the ScummVM file explorer)
• Click Apply (and don't close the LAN tab)
• From a remote PC or other device, open a browser (Chrome) and enter the uri for the server (by default this would look something like ​http://192.168.1.10:12345)
• You might be prompted for insecure connection (since this is not using https), but proceed through this.
• When connected you should see a list of a couple of links, click on "File System Root" which should take you into the ScummVM external app storage, you've set up as the "/root/ Path". This will by default by an empty folder.
• Then click on the "Create Directory" button above, name a directory and click on the "Create Directory" button below the name field.
• Result is "Error Occurred"
• Also try to upload a file (click on the "Upload files" button above, choose a file or folder to upload and then click on the "Upload files" button below. The result will be an "Invalid path" error (for a file upload) or a connection reset (for a folder).

This is issue does not happen on ScummVM 2.8.1.1 for Android.

[antoniou79]

Update: The issue remains if the root folder for the LAN is a SAF-accessed folder.

[lephilousophe]

This is fixed in 400854663181dd9028a8d1df77f8be5de770e9ef.
There was a bug when uploading or creating a directory at the root.