SCUMM: COMI: credits text missing when subtitles are disabled.

[mlauss2]

ScummVM-2.8.1 Linux-x86_64, ScummVM-2.8.1.1 Android
Game "The Curse of Monkey Island (Windows/English)" / id "comi"

The overlay text "Deep in the Caribbean" "Monkey Island" and the Credits Text of the intro "OPENING.SAN" file are missing unless subtitles are enabled.
However with subs enabled also spoken dialogue is subtitled, which is unwanted.

As far as I understand these are all "TEXT" resources embedded into the SAN file; maybe there's a way to force-enable subtitles for a specific timerange? I've noticed that the "mandatory" subtitles of the Intro are prefixed with "/ds_", the credits with "/ec_" while all other dialogue with e.g. "/INGT" and so forth, which is used to translate the text in smush_player.cpp/handleTextResource(). Maybe this could be extended to force enable certain subtitles?

"optional" subs:
/OPGT515/^f00c031Oh, why do I torture myself like this? I might as well wish for some chicken and a big mug of grog for all the good it will do me.
/OPGT520/^f00c031Oh, my sweet Elaine...am I cursed to starve here on this ocean...without seeing your face just one more time? Am I--

"mandatory" subs:
/ds_004/^f04c032Deep in the Caribbean
/ds_005/^f04c032Monkey Island
/ec_493/^f04c001STARRING
/ec_494/^f00c001Dominic Armato
/ec_495/^f00c001as
/ec_496/^f00c001Guybrush Threepwood
/ec_497/^f00c001Doyle Gilstrap
/ec002/^f04c001PROGRAMMED BY
/ec003/^f00c001Chuck Jordan

Thanks!

Manuel

[AndywinXp]

Hi! On 2.9.0git I'm seeing the correct behavior. Could you please test the daily build and confirm this?

Because if this is broken on 2.9.0git then we'll raise priority to High, but it seems to work correctly for me.

[eriktorbjorn]

Unless I completely misunderstand, I'm seeing the correct behavior on Android ScummVM 2.8.1.1.

Each subtitle has a 16-bit "flags" value, and one of these bits apparently indicate that the subtitle is tied to the subtitles setting. A comment in the code says, "if subtitles disabled and bit 3 is set, then do not draw", and that bit is not set on the mandatory subtitles.

That comment has been there since at least ScummVM 0.3.0 which was released close to 22 years ago, so it seems something else must be going on here.

The only thing I can think of is if the movie files were compressed (I think there is still support for that?), and the compression tool accidentally threw away that data. I think something like that did happen in the past, but I stopped using the compression tools when disk space became more plentiful so I haven't kept up.

[mlauss2]

I rebuilt all my linux binaries, redownloaded the gog version of comi; purged the android versions and redownloaded them as well, now it's working as intended.
I have no idea what happened, but I was staring at empty credits before I made this bugreport.
Sorry for the noise.