Opened 7 days ago

Closed 7 days ago

Last modified 5 days ago

#15464 closed defect (fixed)

DGDS: Almost all SCI games detected as Johnny Castaway and others

Reported by: sluicebox Owned by: bluegr
Priority: blocker Component: Engine: DGDS
Version: Keywords:
Cc: Game:

Description

All SCI0/SCI1 games (and maybe others) are being detected as at least one of the DGDS games. I really really don't want release 2.9.0 to involve attesting that "no, no, that's not Johnny Castaway" on every SCI add =)

I know that the file names overlap, but the hashes don't seem to be having an affect here. The SCI game is correctly detected by hash, no other SCI game is mistaken for it, but it's always triggering at least one of Johnny Castaway and Turbo Science even though the hashes and the file sizes don't match.

Examples: brain1, laurabow1, eco1, iceman, kq4, kq4, qfg1, qfg2... anything before SCI1.1 apparently.

Attachments (1)

scummvm-00000.png (39.2 KB ) - added by sluicebox 7 days ago.

Download all attachments as: .zip

Change History (4)

by sluicebox, 7 days ago

Attachment: scummvm-00000.png added

comment:1 by Filippos Karapetis <bluegr@…>, 7 days ago

In b90d520:

DGDS: Add the executables for Johnny and Quarky to the detection tables

This avoids clashes with the SCI games, which have the same file names.
Fixes bug #15464

comment:2 by bluegr, 7 days ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed

Fixed by adding the executables for Johnny and Quarky to the DGDS detection tables, which are unique and don't clash with the SCI game file names.

Thanks for the report! Closing

comment:3 by sluicebox, 5 days ago

Thank you! If this ends up needing something more complicated, let me know and I can try to help. (Maybe we don't want to require an executable if the engine doesn't use it),

My main concern was removing this conflict from release 2.9.0, so I'm happy =)

Note: See TracTickets for help on using tickets.