#1583 closed defect (invalid)
SMUSH: Slowdown during smush playback
Reported by: | SF/dirtyhairy | Owned by: | Kirben |
---|---|---|---|
Priority: | normal | Component: | Engine: SCUMM |
Version: | Keywords: | ||
Cc: | Game: | The Dig |
Description
I noticed this bug two times; once a while ago using a CVS version (dunno when exactly, shortly after the 5.0 release, I think) on a k6-2, 500 mHz running Mandrake 9.0 (kernel 2.4.19) to play comi, and now playing The Dig on a p2, 400 mHz, again with Mandrake 9.0 (but kernel 2.4.24): after a second or so, smush playback slows down and starts skipping frames. Oddly, things go back to normal and play nice and smoothly when I start moving around the mouse (!), but if I stop, it slows down again. I hacked around this for me by changing smush_player.cpp so that SmushPlayer::Play warps the mouse every now and then (after trying in vain to find out what really causes that weird beviour) - works fine, but surely is no real solution. I attached the file, but it really is a bad, bad hack ;)
Ticket imported from: #929778. Ticket imported from: bugs/1583.
Attachments (1)
Change History (13)
by , 21 years ago
Attachment: | smush_player.cpp added |
---|
comment:1 by , 21 years ago
comment:3 by , 21 years ago
Owner: | removed |
---|---|
Summary: | Slowdown during smush playback → SMUSH: Slowdown during smush playback |
comment:4 by , 21 years ago
Which SMUSH movie(s) are you talking about in particular? Can you give one concrete example?
This sounds a bit as if the screen wasn't updated often enough by smush... odd, though, I never noticed anything like this (on a G4 with 400 Mhz). If I compile w/o any optimizations, then it gets a bit slow, but that's it...
comment:5 by , 21 years ago
Owner: | set to |
---|
comment:6 by , 21 years ago
Owner: | removed |
---|
comment:7 by , 21 years ago
BTW I don't think we need a patch from Christian - I looked at the modified .cpp, and yeah, calling warp_mouse() most definitely isn't the solution.
Christian, does it help any if you modifiy the delay in SmushPlayer:: play(), e.g. remove / comment out the _vm->_system->delay_msecs(10);
comment:8 by , 21 years ago
I tried removing the delay, but this didn't help. Smush movies I tried are the dig and comi intros. Both systems (I just got home and tried it on my desktop - the k6-2) us the libSDL 1.2.4 that shipped with Mandrake. I will compile newer SDL and link against it to see if it helps when I find time, though.
comment:9 by , 21 years ago
Bad luck is me: I compiled a new libsdl 1.2.7, but I can't find my dig CD :( . Well, anyway, I tried COMI (after all, t'was the same issue here), the slowdown is gone here. I'll try the dig as soon as I find my CD again. Nevertheless, I think this can be closed - it seems to have been a SDL issue...
comment:10 by , 21 years ago
Status: | new → closed |
---|
comment:11 by , 15 years ago
Owner: | set to |
---|---|
Resolution: | → invalid |
comment:12 by , 6 years ago
Component: | --Unset-- → Engine: SCUMM |
---|---|
Game: | → The Dig |
which SDL version do you use?
Can you (a) comply your patch with our formatting standards (b) submit diff -u old/smush_player.cpp new/smush_player.cpp