#1600 closed defect (fixed)
MI2: Crash because of object overflow in part4.
| Reported by: | SF/michel75 | Owned by: | eriktorbjorn |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: | Monkey Island 2 |
Description
Right, here is the savegame for the object overflow (max=50).
Running the 0.7.0 cvs (14 april).
Ticket imported from: #936323. Ticket imported from: bugs/1600.
Attachments (2)
Change History (16)
comment:1 by , 21 years ago
| Owner: | set to |
|---|
comment:2 by , 21 years ago
comment:4 by , 21 years ago
I can reproduce the crash with this save game. Fingolfin, I seem to recall that you have a different MI2 version than I do so the savegame might not help you after all. If so, is there any debugging output I can provide that would help you determine what's wrong?
I can tell that it's loading 49 object name resources. If I managed to get the names correctly, there are some that don't make any immediate sense to me, but most of them seem reasonable enough.
comment:5 by , 21 years ago
It wasn't specified, but I assume this savegame is for the PC English version of MI2, which I don't own, so I can't try this out :-/
comment:6 by , 21 years ago
That's why I offered to provide debugging output.
Anyway, my uninformed guess would be that MI2 really does change the name of more than 50 objects, and unless there's a way of determining when any of these objects will never been seen again so that they can be removed from the list (this seems unlikely to me), the only thing we can do is to increase the size of that list.
comment:7 by , 21 years ago
| Owner: | changed from to |
|---|
comment:8 by , 21 years ago
Sounds good to me. Increasing this to 100 object slots will only cost us 4*50 = 200 additional bytes of heap anyway. Feel free to try this out and commit a fix :-)
comment:10 by , 21 years ago
Looks fine to me. In fact, we could just increase the limit to 100 for all the games...
comment:11 by , 21 years ago
When you say "for all the games", do you mean all games in that particular case (i.e. just remove the check for MI2 that I added), or do you mean changing it for every game that doesn't read the value from the resource files?
comment:12 by , 21 years ago
Oh, what the heck. I've removed the MI2 check, but I haven't changed the value for the older versions. We can always extend those later, if the need arises.
This bug - and hopefully #933610 as well - should be fixed in CVS now.
comment:13 by , 21 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:14 by , 6 years ago
| Component: | → Engine: SCUMM |
|---|---|
| Game: | → Monkey Island 2 |
There aren't any files attached. Did you forget to check the "Check to Upload and Attach a File" box?