#2083 closed defect (fixed)
MIDI: SysEx API is not used consistently
| Reported by: | fingolfin | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Audio: MT32 |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
Our MidiDriver::sysEx() method is not used consistently; I guess that's partially because it's not really clearly documented (we should fix that, once we have determined *what* it should do, precisely :-).
Right now, most of our MidiDrivers (but not all) expect sysEx() to receive sysEx data w/o the leading 0xF0 and the trailing 0xF7.
Some of the client code complies to that; but there are other places where we call sysEx with data which already includes the 0xF0 / 0xF7.
So, we should decide which behaviour we prefer. Once we have done that, we should fix all MidiDrivers and all places where sysEx() is called to comply to that specification. And of course it should also be documented in a doxygen commen in mididriver.h!
Ticket imported from: #1231434. Ticket imported from: bugs/2083.
Change History (5)
comment:1 by , 19 years ago
comment:2 by , 19 years ago
| Owner: | set to |
|---|
comment:3 by , 19 years ago
| Owner: | removed |
|---|
comment:4 by , 18 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:5 by , 6 years ago
| Component: | --Unset-- → Audio: MT32 |
|---|
Hi Jamieson630... since you've apparently had some time for ScummVM recently, maybe you are interested in taking a look at this issue...?