#2455 closed defect (fixed)
GOB1: Invalid reads during startupy
| Reported by: | Kirben | Owned by: | DrMcCoy |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Gob |
| Version: | Keywords: | ||
| Cc: | Game: | Gobliiins |
Description
Using latest ScummVM 0.9.0 CVS. Compiled with GCC 3.3.6, under Topologilinux 6.0.0. CD version of Gobliins (English).
Valgrind reports several invalid reads when loading palette, as Gobliins starts up. See the attached log.
Ticket imported from: #1402511. Ticket imported from: bugs/2455.
Attachments (1)
Change History (6)
by , 19 years ago
comment:1 by , 19 years ago
| Summary: | GOB1: Ivalid read during startup → GOB1: Invalid reads during startup |
|---|
comment:2 by , 19 years ago
Looks like the one I was telling sev about yesterday, where setFullPalette() is called (I believe) on the 16-colour _vgaPalette[] in gob/global.h.
I don't know enough about the Goblins engine to fix it. At least not at this time.
comment:3 by , 19 years ago
| Status: | new → closed |
|---|---|
| Summary: | GOB1: Invalid reads during startup → GOB1: Invalid reads during startupy |
comment:4 by , 19 years ago
There are actually two _vgaPalette[]s, one in gob/global.h and one in gob/draw.h, when I wrapped the whole code into classes, I assumed the one in gob/init.cpp to be the wrong one, I guess... Should be fixed now...
comment:5 by , 15 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
Note:
See TracTickets
for help on using tickets.
Valgrind log