#537 closed defect (fixed)
DOTT: heavy "white" bug
Reported by: | SF/andrej4000 | Owned by: | SF/ender |
---|---|---|---|
Priority: | high | Component: | Engine: SCUMM |
Version: | Keywords: | ||
Cc: | Game: | Day of the Tentacle |
Description
1) litlle bug: when in past the 3 guys jump out of the windows, the animation of them is missing, you see just their white silouetts.
2) havy bug: When in the future you dress Laverne, the background bitmap in every room in the future disappears, you just see the white...
I played the english DOTT Talkie with CVS from 5th November.
Ticket imported from: #634424. Ticket imported from: bugs/537.
Attachments (2)
Change History (11)
by , 22 years ago
Attachment: | tentacle.s03 added |
---|
comment:1 by , 22 years ago
Priority: | normal → high |
---|
comment:2 by , 22 years ago
This bug was introduced by a change to setPaletteFromPtr() in revision 1.47 of gfx.cpp. The current version is clearly wrong, because in the case of Laverne DOTT will set colours 16-191 and 207 to solid white (255 255 255), while the old version leaves them unchanged.
What would make the most sense to me would be if 255 255 255 was the only colour that meant "leave this colour unchanged", but I have no evidence whatsoever to confirm this theory.
comment:3 by , 22 years ago
No, the disassembly actually makes that exact (if r < 0xFC || g <
0xFC...) comparison. Oddly.
I've commited a fix for it, although you'll need to leave and reenter the room for the savegame to correct itself.
comment:4 by , 22 years ago
Owner: | set to |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:5 by , 22 years ago
Owner: | removed |
---|---|
Status: | closed → new |
comment:6 by , 22 years ago
Newer games like DIG use really the solid white, so a check for scumm version should be set.
comment:7 by , 22 years ago
Status: | new → closed |
---|
comment:9 by , 15 years ago
Owner: | set to |
---|
white backgound