Opened 8 years ago
Closed 4 years ago
#7171 closed defect (fixed)
SWORD25: Casting away const-ness without an explicit const_cast
| Reported by: | DrMcCoy | Owned by: | digitall |
|---|---|---|---|
| Priority: | blocker | Component: | Engine: Sword25 |
| Version: | Keywords: | ||
| Cc: | Game: | Broken Sword 2.5 |
Description
GCC's -Wcast-qual complains about the casting away of cost-ness with a C-style cast in various lua files in sword25:
- engines/sword25/util/lua/ldblib.cpp:213
- engines/sword25/util/lua/ldblib.cpp:249
- engines/sword25/util/lua/ldblib.cpp:254
As well as through the use of the sentinel macro in engines/sword25/util/lua/loadlib.cpp:128. Usages of that macro in:
- engines/sword25/util/lua/loadlib.cpp:138
- engines/sword25/util/lua/loadlib.cpp:161
- engines/sword25/util/lua/loadlib.cpp:168
Ticket imported from: bugs/7171.
Change History (4)
comment:1 by , 8 years ago
| Component: | → Engine: Sword25 |
|---|
comment:2 by , 6 years ago
| Game: | → Broken Sword 2.5 |
|---|
comment:3 by , 4 years ago
| Priority: | low → blocker |
|---|
comment:4 by , 4 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
These have been silenced in 5199f9d080a30b4f3101d00f795ecb0557d522ab. The proper fix would require too much invasion in the vendor code.