#7983 closed patch
Channel_MP3_CDMUSIC volume
| Reported by: | eriktorbjorn | Owned by: | SF/ender |
|---|---|---|---|
| Priority: | normal | Component: | Audio |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
This patch, which was made against a CVS snapshot from July 18, should make Channel_MP3_CDMUSIC take its volume setting from music_volume instead of sfx_volume. I think this makes sense, even if MI1 does use it for some ambient sound effects.
Ticket imported from: #583812. Ticket imported from: patches/88.
Attachments (1)
Change History (8)
by , 22 years ago
| Attachment: | mp3volume.diff added |
|---|
comment:1 by , 22 years ago
| Owner: | set to |
|---|
comment:2 by , 22 years ago
Applied, thanks :)
Do you agree to have this code relicensed in the future? We may be changing from the GPL to another (still open-source) license soon'ish.
comment:3 by , 22 years ago
Of course! It's such a trivial change, but even if it wasn't it would still be extremely ungrateful of me to refuse. I mean, if it wasn't for ScummVM I might never have had the chance to play these LucasArts games at all!
(Of course, thanks should also go to the LucasArts store for still selling the games, and to their legal department for drawing my attention to ScummVM in the first place. ;-)
comment:5 by , 22 years ago
| Status: | new → closed |
|---|
comment:7 by , 6 years ago
| Component: | → Audio |
|---|
Diff against a CVS snapshot from July 18