#7993 closed patch
Simon save directory
| Reported by: | eriktorbjorn | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Engine: AGOS |
| Version: | Keywords: | ||
| Cc: | Game: | Simon the Sorcerer 1 |
Description
I noticed that the Simon games uses a different, more primitive (older?) mechanism for deciding where to put saved games. This patch should fix that.
Ticket imported from: #587694. Ticket imported from: patches/98.
Attachments (3)
Change History (9)
by , 22 years ago
| Attachment: | simonsave.diff added |
|---|
comment:1 by , 22 years ago
I seem to have messed up the patch file somehow. This one should work. (Famous last words.)
comment:2 by , 22 years ago
You should *not* access g_scumm from Simon code. Rather, put the shared code into a common helper function or common class or something, which both Simon and Scumm share.
comment:3 by , 22 years ago
I see your point. Would this patch be more acceptable? It puts GetSavegameDir() in util.cpp instead. (Where it still uses g_scumm, but that's only because I don't know any better. It could easily be eliminated by adding a parameter to the function.)
comment:4 by , 22 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:5 by , 22 years ago
Thanks for your work, Erik. In the end I put this into the (rather new) Engine class, where it can easily be shared.
comment:6 by , 6 years ago
| Component: | → Engine: AGOS |
|---|---|
| Game: | → Simon the Sorcerer 1 |
Patch made against a July 27 snapshot