#8106 closed patch
OpenGL: small bug fixed
| Reported by: | SF/luke_br | Owned by: | Kirben |
|---|---|---|---|
| Priority: | normal | Component: | Graphics |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
I really think this was the last one. It was a problem with the menu drawing when the mouse passed through it.
Ticket imported from: #628356. Ticket imported from: patches/211.
Attachments (6)
Change History (13)
by , 22 years ago
| Attachment: | sdl_gl.diff added |
|---|
comment:1 by , 22 years ago
| Owner: | set to |
|---|
comment:2 by , 22 years ago
Patch as been added to scummvm cvs. An OpenGL build of scummvm is much darker than a normal build of scummvm though. Check the attached pictures, any ideas ?
by , 22 years ago
| Attachment: | scummvm.jpg added |
|---|
by , 22 years ago
| Attachment: | scummvmgl.jpg added |
|---|
comment:3 by , 22 years ago
Well, I use SDL_SetGamma(). But it doesn't seem to work in fullscreen on Linux, just on Windows. The other options is to 'shift left' the bits of each color component (I draw in opengl using RGB textures). So, the problem may be that a 16 bit color depth (565 or 555) has less bits then the 24 bit RGB (888). I will try to compile on a windows machine to see if it's the problem. From what i see at the picture, it got the wrong colors (maybe you are using a 16 bit and 555 pixel format. Max has experienced the same problem, but I use SDL_GetRGB() which shouldn't cause this).
comment:4 by , 22 years ago
I just found out what the problem was. SDL_SetVideoMode was always setting the color depth of the screen to 32 bits (if the X color depth is greater then 16 bit). Now I force the sdl_tmpscreen to be 16 bit with 565 ordering (doesn't make a difference in the game). Everything is drawn correctly in any color depth now. The 2 new diff's are attached.
comment:5 by , 22 years ago
| Status: | new → closed |
|---|
comment:7 by , 6 years ago
| Component: | → Graphics |
|---|
SDL/GL: Small bug fixed