#8199 closed patch (wontfix)
SKY: Possible fix for crash when changing scaler
| Reported by: | eriktorbjorn | Owned by: | SF/khalek |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Sky |
| Version: | Keywords: | ||
| Cc: | Game: | Beneath a Steel Sky |
Description
ScummVM sometimes crashes if you change scaler during the CD intro. I think that is because update_screen() is being called from two different threads, without any safety net against races. This patch attempts to fix that, but I'm a bit uncertain about exactly which functions need to be guarded so it may be slightly wrong and/or incomplete.
Ticket imported from: #726713. Ticket imported from: patches/304.
Attachments (1)
Change History (6)
by , 22 years ago
| Attachment: | sky-mutex.diff added |
|---|
comment:1 by , 22 years ago
Hm, I'll have a look at it later today. But it might be a better appproach to put the locking code into the SDL backend itself. Or not. Really need to try.
comment:2 by , 22 years ago
I put mutex code into the SDL backend, which should make this patch obsolete. Note that other backends (morphos, palmos, wince,...) may have to be enhanced to support multiple threads properly, too.
comment:3 by , 22 years ago
scaler changing works fine here with cvs now, closing as I don't see a reason for this to stay open
comment:4 by , 22 years ago
| Owner: | set to |
|---|---|
| Resolution: | → wontfix |
| Status: | new → closed |
comment:5 by , 6 years ago
| Component: | → Engine: Sky |
|---|---|
| Game: | → Beneath a Steel Sky |
Patch against an April 23 CVS snapshot