Opened 21 years ago

Closed 21 years ago

Last modified 6 years ago

#8245 closed patch (wontfix)

ALL: "read_only" flag for the config file

Reported by: eriktorbjorn Owned by: eriktorbjorn
Priority: normal Component: --Other--
Version: Keywords:
Cc: Game:

Description

I like to keep the games in my .scummvmrc or scummvm.ini sorted, with comments about what they are, how playable they are, etc. Of course, that's all lost when ScummVM decides to write a new config file for me.

This patch is a quick attempt at adding a "read_only" flag to keep ScummVM from ever trying to write the file anew. Is this a reasonable idea? It will, of course, be off by default.

While doing this, I noticed how badly documented the config file format is. I've made an initial attempt at writing something up, but there are a few keywords that I don't know what they are myself.

Ticket imported from: #750001. Ticket imported from: patches/350.

Attachments (2)

config-read-only.diff (1.8 KB ) - added by eriktorbjorn 21 years ago.
Patch against a June 5 CVS snapshot
config-readme.diff (2.7 KB ) - added by eriktorbjorn 21 years ago.
Documentation patch against a June 5 CVS snapshot

Download all attachments as: .zip

Change History (7)

by eriktorbjorn, 21 years ago

Attachment: config-read-only.diff added

Patch against a June 5 CVS snapshot

by eriktorbjorn, 21 years ago

Attachment: config-readme.diff added

Documentation patch against a June 5 CVS snapshot

comment:1 by fingolfin, 21 years ago

Personally I think this isn't really a good solution for the problem, more a hackish workaround (no offense intended - it certainly works, but in a suboptimal way).

It would make much more sense to have a better config file implementation which touches config files as little as possible (i.e. only inserting/removing lines). And of course the GUI should be improved to a state where manually editing the config file isn't necessary anymore either.

comment:2 by eriktorbjorn, 21 years ago

If that can be done, I agree it's a better solution. I still think the config file format ought to be documented though.

comment:3 by eriktorbjorn, 21 years ago

Since the config file format is at least better documented now, and this particular approach appear to be a dead end, I might as well reject the patch myself. :-)

comment:4 by eriktorbjorn, 21 years ago

Owner: set to eriktorbjorn
Resolution: wontfix
Status: newclosed

comment:5 by digitall, 6 years ago

Component: --Other--
Note: See TracTickets for help on using tickets.