#8250 closed patch (outdated)
ALL: Enabling different aspect ratio correction methods
| Reported by: | eriktorbjorn | Owned by: | eriktorbjorn |
|---|---|---|---|
| Priority: | normal | Component: | Graphics |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
This patch makes it possible to switch between different aspect ratio correction modes (which can be useful e.g. if "exact" is too slow) with Ctrl-Alt-a. I've updated both the SDL and OpenGL backends, but I haven't given the latter much testing really.
In my highly unscientific tests, I concluded that "sloppy" is alittle faster than "fast", "exact" is the slowest by far, and I usually can't tell any difference between the output of "fast" and "exact".
The patch is not quite backwards compatible with current behaviour:
I've changed the --aspect-ratio command line option to -r<mode>. This is partly because I can't be bothered to write code to handle long options properly right now. It should be noted that -r has been reserved as a no-op for backwards compatibility since 0.2.0 or earlier. I haven't checked what it used to do.
Putting "aspect_ratio=true" in .scummvmrc / scummvm.ini no longer works since "true" is not a valid mode. This could be a problem since ScummVM refuses to start if there are this kind of errors in the config file.
Ticket imported from: #760282. Ticket imported from: patches/355.
Attachments (2)
Change History (7)
by , 21 years ago
| Attachment: | aspect-modes.diff added |
|---|
comment:1 by , 21 years ago
The old patch no longer applies cleanly. This one should, for a while at least.
comment:2 by , 21 years ago
A simpler method would, of course, be to just use the "fast" mode since that's good enough (in my opinion) and much faster than the "exact" mode.
comment:3 by , 21 years ago
| Owner: | set to |
|---|---|
| Resolution: | → outdated |
| Status: | new → closed |
comment:4 by , 21 years ago
...and just as I wrote that, the change was made. I guess this is out of date now, then.
comment:5 by , 6 years ago
| Component: | → Graphics |
|---|
Patch against a June 24 CVS snapshot