#8335 closed patch
FOTAQ - additional hebrew support
| Reported by: | salty-horse | Owned by: | |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Queen |
| Version: | Keywords: | ||
| Cc: | Game: | Flight of the Amazon Queen |
Description
* Fixed reverse order of lines in dialogue chooser, when one sentence is "wrapped" over several lines <queen/talk.cpp> * Fixed "save entry" text in the journal (originally appears, even in the exe, as "entry save") <queen/journal.cpp>
The code in talk.cpp is a bit messy, I'd appriciate any feedback.
note: The patch is for the cvs HEAD.
Ticket imported from: #910779. Ticket imported from: patches/440.
Attachments (1)
Change History (7)
by , 21 years ago
| Attachment: | hebrew2.diff added |
|---|
comment:1 by , 21 years ago
comment:3 by , 21 years ago
We're waiting for an updated (rewritten ?) patch from the original submitter.
comment:5 by , 21 years ago
| Status: | new → closed |
|---|
comment:6 by , 6 years ago
| Component: | → Engine: Queen |
|---|---|
| Game: | → Flight of the Amazon Queen |
Note:
See TracTickets
for help on using tickets.
You want some feedback, here it is :-).
As a comparaison, I looked at the original implementation of split_option() in the hebrew executable. A 'C' rewrite is here : http://membres.lycos.fr/cyxdown/scummvm/fotaq/split_option _heb.cpp
Another (purely cosmetic) suggestion is to add to the Talk class 2 methods to split the option lines (ie, one for reversed/hebrew and one for default/english). Then, Talk::splitOption() would simply have to call the appropriate function.