#8423 closed patch
GM/GS/MT-32 Init Patch
| Reported by: | SF/tbcarey | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Audio: MT32 |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
Patch to the earlier quicky patch. It should fix the following things:
1) Prevent FMTowns games from initializing as MT32 or GM or GS, which in turn prevents a crash caused by GS init calling midi->getPercussionChannel(), which YM2162 driver seems to be unable to handle (at least in this case).
2) Prevents null midi games from doing the same, when they shouldn't anyway.
3) Prevents MT-32 emulation (Munt) from doing GS init, which can mess up some of its percussion settings, etc.
The first two problems are caused because any non-Adlib sound driver that uses the imuse parser (as opposed to pc speaker, pcjr which don't) will return true for _midi_native. This shouldn't be the case, but it appears that _midi_native is only set up to be opposed to _adlib_native, so when if clauses are used to determine if an mt-32/gm specific portion of the code should run, YM2162 and NULL drivers still do so. This should prevent that, although the label '_midi_native' is still somewhat misleading.
Ticket imported from: #1186858. Ticket imported from: patches/528.
Attachments (1)
Change History (14)
by , 20 years ago
| Attachment: | gsfix2.patch added |
|---|
comment:1 by , 20 years ago
comment:2 by , 20 years ago
| Owner: | set to |
|---|
comment:3 by , 19 years ago
| Status: | new → closed |
|---|
comment:5 by , 19 years ago
I'll be able to finish the changes I mentioned within the next two weekends.
comment:6 by , 19 years ago
| Status: | closed → new |
|---|
comment:7 by , 19 years ago
As far as I'm aware, this bug still exists. My earlier patch stopped FMTowns from initialising as GS (in a more kludgy fashion) but MT-32 emulation still allows GS initialisation, which is incorrect and will cause it so sound wrong.
comment:8 by , 19 years ago
Jamieson, may you take a look into this? If not, please, unassign yourself.
comment:9 by , 19 years ago
| Owner: | changed from to |
|---|
comment:11 by , 18 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → closed |
comment:12 by , 18 years ago
I finally commited this -- it doesn't seem likely that kingguppy will return. If it breaks anything, this way at least we'll find out about it; if it doesn't, the much the better.
comment:13 by , 6 years ago
| Component: | → Audio: MT32 |
|---|
I'm currently working on that area of code, so I can't apply the patch directly. The stuff I'm working on cleans up this whole mess.