#8426 closed patch (wontfix)
DC: dcmain.cpp
| Reported by: | SF/erwan2004 | Owned by: | zeldin |
|---|---|---|---|
| Priority: | normal | Component: | Port: Dreamcast |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
Scummvm for dreamcast :
files dcmain.cpp lines 226:
FIXME: This is an evil hack: _detector.parseCommandLine(argc, argv);
But doing it properly isn't that hard, actually:
change :
//FIXME: This is an evil hack: _detector.parseCommandLine(argc, argv);
//But doing it properly isn't that hard, actually:
Ticket imported from: #1189539. Ticket imported from: patches/531.
Change History (8)
comment:1 by , 20 years ago
comment:2 by , 20 years ago
| Owner: | set to |
|---|---|
| Resolution: | → wontfix |
| Status: | new → closed |
comment:3 by , 20 years ago
But in that case you failed in your purpose, as it was not your breaking that drew my attention to the "spot", but rather the patch.
A mail on the list would probably have been more efficient. In particular if it would also suggest what should be done instead.
comment:4 by , 20 years ago
Well, I inserted code that shows what should be done instead, didn't I? :-)
comment:5 by , 20 years ago
Maybe, I haven't actually checked HEAD yet... :-)
Anyway, if a better solution is already in place, there should be no need for broken comments, should there?
comment:6 by , 20 years ago
The code is not fully functional (in particular, this "patch" wouldn't allow the code to be compiled); it should be a trivial matter for anybody with a DC dev system to make it complete, though. But w/o any way to test this, I didn't dare to insert complete code which then could potentially lead to mysterious failures. Hence I inserted a sketch of the proper code, and a comment, hoping that whoever tried to compile the code next would submit a proper fix for the issue (this "patch" isn't it, though, as I said, it won't even fix compilation :-)
comment:7 by , 20 years ago
So it would seem that the plan failed then. :-)
Hopefully I'll have some time to look it through tomorrow.
comment:8 by , 6 years ago
| Component: | → Port: Dreamcast |
|---|
Sorry, I have to reject this patch. The code was broken on purpose to draw the porters attention to the spot, so that it will be fixed the next time he gets a chance to work on it...