#8441 closed patch
SMUSH threads & files
| Reported by: | fingolfin | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
This experimental patch tries to modify the SMUSH player such that all file access is done from within a single thread -- the SMUSH player thread/timer callback.
This should help systems where a file handle can only be accessed from the thread it was created in (EPOC/Symbian).
This also should make it a bit easier to optimize file access, see also bug #1174927.
Ticket imported from: #1227243. Ticket imported from: patches/546.
Attachments (1)
Change History (7)
comment:1 by , 19 years ago
comment:2 by , 19 years ago
Well, if you insist... although I think it would have been far easier if you had just written an appropriate patch based on the item description yourself, tsk tsk! :-)
by , 19 years ago
| Attachment: | smush.patch added |
|---|
comment:3 by , 19 years ago
Well, it still seems to be working like before, which is good.
It doesn't fix the Full Throttle slowdowns, but given your description of the patch I didn't expect it to.
comment:4 by , 19 years ago
Indeed; it's only transforming the code a bit, and moving some file handling code to another thread. The only thing it should affect is EPOC/Symbian; all other systems hopefully work unchanged.
I'll commit this then (if it does cause subtle regressions, we can still back it out again, right?).
comment:5 by , 19 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:6 by , 6 years ago
| Component: | → Engine: SCUMM |
|---|
I'll try it once you attach the file. ;-)