Opened 18 years ago

Closed 18 years ago

Last modified 6 years ago

#8537 closed patch

residual: improve text object resource handling

Reported by: SF/mannythegnome Owned by: aquadran
Priority: normal Component: ResidualVM
Version: Keywords:
Cc: Game:

Description

The attached patch ensures that the resources associated with a killed text object are destroyed (i.e. the bitmap) which prevents residual from becoming a resource hog in the main menu.

I'm not sure whether the delete statement is appropriate at that place, and I don't know enough CPP to judge whether the remove statement is superfluous, i.e. whether the delete statement implies removal from lists.

The patch also removes the TextObjectExists statement from BlastText(), which IMHO isn't neccessary (the object will be destroyed right after it was drawn).

Ticket imported from: #1495487. Ticket imported from: patches/642.

Attachments (1)

residual-text.diff​ (907 bytes ) - added by SF/mannythegnome 18 years ago.
proposed patch

Download all attachments as: .zip

Change History (10)

by SF/mannythegnome, 18 years ago

Attachment: residual-text.diff​ added

proposed patch

comment:1 by SF/mannythegnome, 18 years ago

Hrm the actor.cpp code seem to call delete itself for each sayline deletion, while the deleteTextObjects code of the engine (that deletes all the text objects) does the deletion.

comment:2 by fingolfin, 18 years ago

Owner: set to aquadran

comment:3 by fingolfin, 18 years ago

aquadran, do you think this patch can / should be applied?

comment:4 by aquadran, 18 years ago

i didn't have a time for look close into that patch yet. So i don't know yet.

comment:5 by fingolfin, 18 years ago

Any news on this?

comment:6 by sev-, 18 years ago

What is the status of this item?

comment:7 by aquadran, 18 years ago

stalled, i need look close into changes

comment:8 by aquadran, 18 years ago

Status: new → closed

comment:9 by digitall, 6 years ago

Component: → ResidualVM
Note: See TracTickets for help on using tickets.