#8582 closed patch
add support for FLAC-1.1.3
| Reported by: | SF/jcoalson | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Ports |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
attached is a patch to scummvm-0.9.0 to make the code
work with both the upcoming FLAC 1.1.3 release and
previous versions. a beta of FLAC 1.1.3 is available
here:
http://prdownloads.sourceforge.net/flac/flac-1.1.3-beta2.tar.gz?download
changelog:
http://flac.cvs.sourceforge.net/*checkout*/flac/flac/doc/html/changelog.html
the LEGACY_FLAC stuff can be removed once FLAC-1.1.3
has propagated everywhere.
the patch also should work against CVS HEAD as all
the files affected are the same.
let me know if you have any questions or problems,
I'll be monitoring this tracker item.
Josh
Ticket imported from: #1584720. Ticket imported from: patches/687.
Attachments (1)
Change History (4)
by , 18 years ago
| Attachment: | scummvm_0.9.0_flac_1.1.3.patch.gz added |
|---|
comment:1 by , 18 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:2 by , 18 years ago
comment:3 by , 6 years ago
| Component: | → Ports |
|---|
Note:
See TracTickets
for help on using tickets.
I applied a modified version of the patch to SVN HEAD (CVS HEAD is not used anymore, and no changes will be made there ever again).
Essentially, I added some typedefs to map from old to new types. While this is in a sense a dirty trick, it's not worse than cluttering the code with many #ifdefs, but does improve readability (and helps various IDEs to better parse the functions in that files ;-)).
As for the LEGACY_STUFF being removed eventually: I don't think this will be possible for another couple of years, and strictly spoken, I see no reason to even do it (except for a feeble attempt to help "force" people to migrate to a newer FLAC) :-). Alas, this is nothing that needs discussion, we'll deal with it when we have to.