#8591 closed patch
SWORD2: Fix for the spanish credits
| Reported by: | jvprat | Owned by: | eriktorbjorn |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Sword2 |
| Version: | Keywords: | ||
| Cc: | Game: | Broken Sword 2 |
Description
The replacement of special characters in the credits to fix the german credits was eating lots of characters in the spanish credits. The attached patch makes a fine grained replacement just for the needed characters (it adds a substitution needed for the spanish credits). I just have the spanish version, but I hope it won't break other versions...
Ticket imported from: #1597800. Ticket imported from: patches/696.
Attachments (3)
Change History (10)
by , 18 years ago
| Attachment: | sword2credits.patch added |
|---|
comment:1 by , 18 years ago
I don't really like the "character code -86" thing... What happens if you simply change the char pointer to a byte pointer, like in the attached patch? (If the character still has to be filtered, it should now be 170 instead, I think.)
comment:2 by , 18 years ago
You're right, negative numbers feel strange in this context. I've updated the patch with your proposal.
comment:3 by , 18 years ago
The character's still invalid, then? (It is in the English version, I just wanted to make sure I understand this correctly before applying.) The credits is one thing that ScummVM handles completely different form the original. I don't know if we ever got the source code for that part. (Or if anyone even asked.)
comment:4 by , 18 years ago
Ok, sorry, I didn't understand you before. Your single patch fixed the missing characters, but the 170 code is still showing a checkerboard symbol.
I've read that the speech font is used instead of the original credits font. That may have the missing german and spanish symbols.
comment:5 by , 18 years ago
Maybe. I've been meaning to take a closer look at font.clu some day, which I suspect might be the credits font (I don't think it's used anywhere at the moment, at least). Any year now.
Until then, let's just use your revised patch. The only change I'm making is to change -86 to 170 in the comment, as well. Thanks!
comment:6 by , 18 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:7 by , 6 years ago
| Component: | → Engine: Sword2 |
|---|---|
| Game: | → Broken Sword 2 |
SWORD2: Fix for the spanish credits