#8607 closed patch
KYRA: VQA player code cleanup/reduce
| Reported by: | cyxx | Owned by: | eriktorbjorn |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Kyra |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
I was looking at the VQA player and noticed there was a duplicated function there. Basically, the decode80 routine is the same as Screen::decodeFrame4.
Added patch which removes the duplicated function (among other minor cleanups).
Ticket imported from: #1659302. Ticket imported from: patches/712.
Attachments (1)
Change History (7)
by , 18 years ago
| Attachment: | vqa_player_cleanup.diff added |
|---|
comment:1 by , 18 years ago
I haven't committed this directly, as I wasn't sure if it was done on purpose or not.
Which makes me also think that it could be a nice thing to rename Screen::decodeFrame4 to decodeFormat80 and Screen::decodeFrame3 to decodeFormat40 etc. to match other documentations.
comment:2 by , 18 years ago
Any reason why Screen::decodeFrame4 returns uint32 and not just int (or uint)? That's not that important though. :-)
Well we could rename them, I wouldn't mind if that would be done.
comment:3 by , 18 years ago
> Any reason why Screen::decodeFrame4 returns uint32
No particular reason at all, uint would be fine too
comment:5 by , 18 years ago
| Status: | new → closed |
|---|
comment:6 by , 6 years ago
| Component: | → Engine: Kyra |
|---|
Re-use existing bitmap decoding code