#8613 closed patch
DIMUSE: (Not) Storing mixer flags in savegames
| Reported by: | eriktorbjorn | Owned by: | eriktorbjorn |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
This patch isn't tested much, but it should break the unfortunate dependency on the exact values of the mixer flags that Fingolfin noted earlier today.
If it's applied, we should probably clarify some comments, and the comment in the mixer code could be removed or at least toned down a bit.
Ticket imported from: #1672572. Ticket imported from: patches/718.
Attachments (1)
Change History (5)
by , 18 years ago
| Attachment: | imuse-mixer-flags.diff added |
|---|
comment:1 by , 18 years ago
| Owner: | set to |
|---|---|
| Summary: | DIMUSE: Storing mixer flags in savegames → DIMUSE: (Not) Storing mixer flags in savegames |
comment:2 by , 18 years ago
Looks good to me. Feel free to commit it right away.
I think we should still say in mixer.h that it's not a good idea to store the mixer flags in the savegame, but the ref to iMuseDigital could indeed be removed-
comment:3 by , 18 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → closed |
comment:4 by , 6 years ago
| Component: | → Engine: SCUMM |
|---|
Note:
See TracTickets
for help on using tickets.
Patch against current SVN