#8668 closed patch
INDY3: IQ Points Dialog
| Reported by: | SF/mthreepwood | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: | Indiana Jones 3 |
Description
I'm attaching a simple patch to allow for the 'i' key to call for a simple dialog which lists the episode/series points, although the series points do not work.
Tested with Indy3 VGA DOS.
Ticket imported from: #1727045. Ticket imported from: patches/773.
Attachments (2)
Change History (7)
by , 17 years ago
| Attachment: | indy3_iq_points.diff added |
|---|
comment:1 by , 17 years ago
Some comments:
* Why is _indy3IQPointsDialog when you always delete it in the indy3IQPointsDialog() method anyway? Either turn it into a simple stack var; or you dispose it in the destructor.
* You have a comment "Since series score doesn't work right, set it equal to episode score". We might implement series points at some point; so I think it would be good to mark this accordingly, i.e. mention this possibility, maybe add a "FIXME" tag to make clear that this is not really desirable behavior, just a workaround.
* Any particular reason you pass vars 244/245 as parameters to indy3IQPointsDialog() ?
* In fact, any particular reason to have a indy3IQPointsDialog() method in ScummEngine in the first place? Instead, how about inserting that code directly into processKeyboard() ?
* Independently from the previous comment, it would seem more logical to have the code for 'i' handling insider ScummEngine_v3, i.e. in ScummEngine_v3::processKeyboard()
comment:2 by , 17 years ago
* Ok. Changed into the function
* It's now a FIXME statement
* That function no longer exists. I have comments saying what the variables are (I hope that's what you mean)
* Done. It's in processKeyboard()
* Done. It's moved to ScummEngine_v3
I just hope this patch can get in for 0.10.0 :D File Added: indy3_iq_points_updated.diff
comment:3 by , 17 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:5 by , 6 years ago
| Component: | → Engine: SCUMM |
|---|---|
| Game: | → Indiana Jones 3 |
Patch for IQ Points Dialog