#8747 closed patch
SWORD 1: inverse stereo for traffic in rue Jarry
Reported by: | SF/richiefs | Owned by: | eriktorbjorn |
---|---|---|---|
Priority: | normal | Component: | Engine: Sword1 |
Version: | Keywords: | ||
Cc: | Game: | Broken Sword 1 |
Description
Here is a patch that implements the FR #1266599
Ticket imported from: #1833038. Ticket imported from: patches/852.
Attachments (3)
Change History (17)
by , 17 years ago
Attachment: | sword1-traffic-jarry.diff added |
---|
comment:1 by , 17 years ago
Link to the FR: http://sourceforge.net/tracker/index.php?func=detail&aid=1739042&group_id=37116&atid=418823
comment:2 by , 17 years ago
Good link...: http://sourceforge.net/tracker/index.php?func=detail&aid=1266599&group_id=37116&atid=418823
comment:3 by , 17 years ago
Owner: | set to |
---|
comment:5 by , 17 years ago
It would probably make sense to use the FX_ constants for the sounds, as defined in swordres.h instead of hard-coding the values. But if it's simply that the "left-to-right" and "right-to-left" sound effects havebeen mixed up, wouldn't it be simpler to just fix _fxList[] in swordres.cpp? Or are they used elsewhere for something that's visible on screen?
by , 17 years ago
Attachment: | sword1-traffic-jarry-ressources.diff added |
---|
sword1-traffic-jarry-ressources.diff
comment:6 by , 17 years ago
I updated the patch. It doesn't have anymore hard coded values. I have no idea if these samples are called elsewere. File Added: sword1-traffic-jarry-ressources.diff
comment:7 by , 17 years ago
Owner: | changed from | to
---|
comment:8 by , 17 years ago
Torbjörn, how about doing as you said and fix _fxList[], and we'll find out if that's wrong when somebody complains?
Maybe Robert also has something to add?
comment:9 by , 17 years ago
Here's what the alternative patch would look like. I have assumed that the symbolic name in _fxList[] is correct - for instance, "Truck passes, left to right" is called FX_HVYVEHR, because the truck is travelling to the "R"ight - and changed the #defines instead.
If it doesn't break any other scene, I think it's a much more elegant way of fixing the glitch. File Added: fxlist.diff
comment:11 by , 17 years ago
Owner: | changed from | to
---|
comment:12 by , 17 years ago
I've committed my patch to the trunk. (Not to the branch - it's a feature request, not a bug.)
comment:13 by , 17 years ago
Status: | new → closed |
---|
comment:14 by , 6 years ago
Component: | → Engine: Sword1 |
---|---|
Game: | → Broken Sword 1 |
sword1-traffic-jarry.diff