#8905 closed patch
XMIDI callback control events
| Reported by: | eriktorbjorn | Owned by: | eriktorbjorn |
|---|---|---|---|
| Priority: | normal | Component: | Audio: MT32 |
| Version: | Keywords: | ||
| Cc: | Game: | Simon the Sorcerer 2 |
Description
This patch should be enough to implement the XMIDI callback controller event. Basically, it just adds some optional parameters to createParser_XMIDI(), so that a callback function can be specified.
However, I'm a bit torn... The main reason (for me) would be to silence the warnings in the DOS version of Simon the Sorcerer 2. This is fine, because the game doesn't actually seem to *use* the callback events. But it would also silence the warnings for games where we want the warning, because some feature is actually missing.
So maybe there should be a default callback that prints a message, and any engine that doesn't want this would have to explicitly say so?
Ticket imported from: #2040074. Ticket imported from: patches/1010.
Attachments (2)
Change History (7)
by , 16 years ago
| Attachment: | xmidi.diff added |
|---|
comment:1 by , 16 years ago
Yes, default callback makes sense, and you may even make it truly default, i.e. as a default parameter value (pardon the pun). Could you implement that too?
comment:4 by , 16 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:5 by , 6 years ago
| Component: | → Audio: MT32 |
|---|---|
| Game: | → Simon the Sorcerer 2 |
Patch against current SVN