#8914 closed patch
SCUMM: engine sets incorrect talkspeed value
Reported by: | salty-horse | Owned by: | fingolfin |
---|---|---|---|
Priority: | normal | Component: | Engine: SCUMM |
Version: | Keywords: | ||
Cc: | Game: |
Description
Scumm's talkspeed value is set by the value of _defaultTalkDelay.
This is confusing since the setting is called "subtitle speed". A value of 9 should mean "fastest speed" and not "largest delay" (i.e. slowest speed) as it currently does.
Also, since the the +/- hotkey OSD shows the value of "9 - _defaultTalkDelay", it is inconsistent with the display in the Scumm options menu which shows _defaultTalkDelay.
The patch adjusts the talkspeed value to be "9 - _defaultTalkDelay".
Ticket imported from: #2060517. Ticket imported from: patches/1019.
Attachments (3)
Change History (14)
by , 16 years ago
Attachment: | scumm-talkspeed-slider.patch added |
---|
comment:1 by , 16 years ago
comment:2 by , 16 years ago
Owner: | set to |
---|---|
Summary: | [SCUMM] engine sets incorrect talkspeed value → SCUMM: engine sets incorrect talkspeed value |
comment:4 by , 16 years ago
SF.net seems to be having trouble with file uploading, so here's a temporary copy of the patch: http://paste.lisp.org/display/65809/raw
comment:5 by , 16 years ago
Attachment problems should be fixed now, please attache the missing files. Thanks!
by , 16 years ago
Attachment: | scumm-talkspeed-slider-2.patch added |
---|
Corrected patch. Added missing files.
comment:7 by , 16 years ago
If you change all occurrences of getTalkspeed() to 9 - getTalkspeed() then it would be much easier to change *none* of them, but rather change the code of getTalkspeed(). Same for setTalkspeed().
by , 16 years ago
Attachment: | scumm-talkspeed-slider-3.patch added |
---|
Third patch. Isolated changes to the get/set funcs
comment:10 by , 16 years ago
Status: | new → closed |
---|
comment:11 by , 6 years ago
Component: | → Engine: SCUMM |
---|
Sounds sensible all in all. Will review the patch later, when I have a break on this conference.