Attachments (2)
Change History (15)
by , 16 years ago
| Attachment: | scummvm-0.12.0-motoezx.patch added |
|---|
comment:1 by , 16 years ago
Hi there,
while you don't say it, it seems this patch is about adding support for a new device to ScummVM. Great. But there are some problems with this submission:
* Please tell us what exactly this patch is about; is this some kind of new Phone OS you are supporting with the patch? Or yet another symbian/WinCE variant?
* You seem to just have copied the SDL backend and then modified it. This is not acceptable, I am afraid. However, it is also not necessary. You can can subclass it, like the WinCE and Symbian backends do. If you need help with that, feel free to ask here, and we'll provide some guidance.
* The patch sadly is against 0.12.0, and hence we will not be able to incorporate it :(. Too many things changed in trunk. Please, try to make a patch against trunk.
* It would be helpful if you could create your new patch with the "-u" option for diff; at least I find this "unified" format a lot easier to read :).
Thanks for your efforts :)
comment:4 by , 16 years ago
| Owner: | set to |
|---|---|
| Status: | new → pending |
comment:5 by , 16 years ago
ScummVM Trunk motoezx patch diff -rNu File Added: scummvm-trunk-motoezx.patch
comment:6 by , 16 years ago
| Status: | pending → new |
|---|
comment:7 by , 16 years ago
| Owner: | removed |
|---|
comment:8 by , 16 years ago
The patch in this form is still not OK. First off, you still haven't told us what it is about / what the patch *does* :).
Secondly, it seems to hack-override SDL_PollEvent for *all* ports, pausing / resuming audio input when ScummVM is sent to the background. Not OK. If you need to override code in SDL_PollEvent, the right way is to wrap it into a virtual method of OSystem_SDL, then provide a *new* port which subclasses the SDL port, just as the Symbian and WinCE ports do. If you are not sure how to do that, maybe somebody on the team is interested in helping with that. Or you could ask questions... :)
comment:9 by , 16 years ago
| Status: | new → pending |
|---|
comment:11 by , 16 years ago
| Status: | pending → closed |
|---|
comment:12 by , 16 years ago
This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker).
comment:13 by , 6 years ago
| Component: | → Ports |
|---|
scummvm-0.12.0 Motorola A1200/E6 patch