#8935 closed patch
BS1: Simplified subtitles
| Reported by: | eriktorbjorn | Owned by: | eriktorbjorn |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Sword1 |
| Version: | Keywords: | ||
| Cc: | Game: | Broken Sword 1 |
Description
After a "brief delay" (the original API discussion was about two years ago), I've decided that the lockScreen() / unlockScreen() functions are, in fact, almost exactly what I need to simplify the drawing of the cutscene subtitles in Broken Sword 1.
(I can't draw them to the decoded frame, because that's one of the decoder's internal buffers, and besides it may be much smaller than the actual screens, so the subtitles might not fit.)
I'm a bit worried that doing it this way will slow things down. I seem to recall that one reason to use the smaller (low-quality) cutscenes was so that hand-held devices would have an easier time playing them. With this patch, there will be full-screen updates every frame. But maybe the bottleneck wasn't the screen updates, but the frame decoding?
Ticket imported from: #2219361. Ticket imported from: patches/1040.
Attachments (1)
Change History (7)
by , 16 years ago
| Attachment: | bs1-subtitles.diff added |
|---|
comment:1 by , 16 years ago
| Owner: | set to |
|---|
comment:2 by , 16 years ago
| Owner: | changed from to |
|---|
comment:3 by , 16 years ago
Let's commit it and see how it will affect smaller devices. As I understand, it updates most of the screen anyway, so perhaps little or no impact will take place, but the code is much cleaner.
comment:4 by , 16 years ago
I can't do it right now, but I'll try to remember to this evening.
You're right that normally most of the screen would be updated. I think only one of the high-quality Smacker cutscenes (which is what our re-encoded cutscenes are made from) is significantly smaller than the screen.
My concern was if you've re-encoded the low-quality Smacker cutscenes instead. I seem to remember some discussion about them working better on hand-held devices. But, as I said, I don't know if the bottleneck is the screen updates, or the frame decoding.
comment:5 by , 16 years ago
| Status: | new → closed |
|---|
comment:6 by , 6 years ago
| Component: | → Engine: Sword1 |
|---|---|
| Game: | → Broken Sword 1 |
Patch against current SVN