#8975 closed patch
Buffer Overflow
| Reported by: | SF/reddwarf69 | Owned by: | wjp |
|---|---|---|---|
| Priority: | normal | Component: | --Other-- |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
From openSUSE rpmlint... I: Statement might be overflowing a buffer in strncat. Common mistake: BAD: strncat(buffer,charptr,sizeof(buffer)) is wrong, it takes the left over size as 3rd argument GOOD: strncat(buffer,charptr,sizeof(buffer)-strlen(buffer)-1) E: scummvm bufferoverflowstrncat engines/saga/sfuncs.cpp:1573 E: scummvm bufferoverflowstrncat engines/scumm/he/logic_he.cpp:89
No especially efficient (too much strlen()) but fixes the problem.
Ticket imported from: #2671477. Ticket imported from: patches/1080.
Attachments (1)
Change History (4)
by , 16 years ago
| Attachment: | scummvm-0.13-bufferoverflow.patch added |
|---|
comment:2 by , 16 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:3 by , 6 years ago
| Component: | → --Other-- |
|---|
Note:
See TracTickets
for help on using tickets.
Fix