#8991 closed patch
Gob engine : Some more MD5s and Fascination's skeleton
Reported by: | Strangerke | Owned by: | Strangerke |
---|---|---|---|
Priority: | normal | Component: | Engine: Gob |
Version: | Keywords: | ||
Cc: | Game: | Fascination |
Description
- Added some more MD5 to the Gob detection engine (Playtoon 1 and 2, Fascination, Geisha) - Added inter and draw skeleton for Fascination - Added a switch to define to first STK to load based on the game type
Ticket imported from: #2725859. Ticket imported from: patches/1096.
Attachments (11)
Change History (16)
by , 16 years ago
Attachment: | Gob_Strangerke_090401.patch added |
---|
comment:1 by , 16 years ago
Owner: | set to |
---|
by , 16 years ago
Attachment: | Gob_Strangerke_090402.patch added |
---|
Add some code in the 'unknown' functions, plug in the Protracker function, modify parser use to v1, split Playtoon in two, to easy future work
by , 16 years ago
Attachment: | Gob_Strangerke_090403.patch added |
---|
Gob: Add Windows version of Gob trilogy. Add atypic version of Last dynasty demo
by , 16 years ago
Attachment: | Gob_Strangerke_090403_MD5.patch added |
---|
Add MD5 for Windows version of Gob trilogy, atypic 'last dynasty' demo and an adibou v4 game
comment:2 by , 16 years ago
Sorry for the late answer.
Anyway, looking good so far. :) Some notes though (most of which I already told you on IRC):
1. There's one tab too many at the switch in gob.cpp 2. Use "fascination" not "fascin" as a game ID for Fascination 3. In the detection array, don't change the capitalization of the game ID 4. One game ID for Fascination ("fascination"), not "fascin" and "fascin2" 5. You should probably introduce a new field in the detection array for the STK that's loaded on game start 6. Likewise, maybe adding a "Features" flag value for "0OT" instead of "TOT" would be prudent as well 7. Use AD_ENTRY1s() instead of AD_ENTRY1() in the detection array, including the size of the data file. So that MD5 collisions can be minimized (especially since only the first 5000 bytes of the files are measured)
by , 16 years ago
Attachment: | Gob_Strangerke_090406.patch added |
---|
Change Game id from fascin to fascination, Add a new field in detection array
by , 16 years ago
Attachment: | Gob_Strangerke_090406_MD5.patch added |
---|
Add a new field in detection array, replace AD_ENTRY1 by AD_ENTRY_1s on added MD5
by , 16 years ago
Attachment: | Gob_Strangerke_090407_v2.patch added |
---|
Gob - Add support to Fascination CD (hand generated Stk files), replace standard initialisation by '0' in order to shorten detection code
by , 16 years ago
Attachment: | Gob_Strangerke_090407_v3.patch added |
---|
Gob - Fix detection of Playtoon games. Add missing spaces in AD_ENTRY1s calls. Split check of baseTot and baseStk.
comment:3 by , 16 years ago
Owner: | removed |
---|
comment:4 by , 16 years ago
Owner: | set to |
---|---|
Status: | new → closed |
comment:5 by , 6 years ago
Component: | → Engine: Gob |
---|---|
Game: | → Fascination |
GOB: Skeleton for Fascination + MD5s