Opened 16 years ago

Closed 16 years ago

Last modified 6 years ago

#8999 closed patch

GSOC09: Dragon History engine detection/stub

Reported by: SF/dkasak13 Owned by: sev-
Priority: normal Component: Engine: Draci
Version: Keywords:
Cc: Game: Dragon History

Description

Here's my patch for GSOC. It's against revision 39903. The patch contains basic class definitions and detection code for the Dragon History engine. I'm sorry I haven't had time for a more elaborate patch (university obligations). :-)

Ticket imported from: #2746286. Ticket imported from: patches/1104.

Attachments (2)

dragon.patch (9.0 KB ) - added by SF/dkasak13 16 years ago.
Dragon History engine detection/stub
dragon2.patch (9.4 KB ) - added by SF/dkasak13 16 years ago.
The real patch, against revision 39948

Download all attachments as: .zip

Change History (9)

by SF/dkasak13, 16 years ago

Attachment: dragon.patch added

Dragon History engine detection/stub

comment:1 by fingolfin, 16 years ago

So.. why didn't you test it? :)

comment:2 by SF/dkasak13, 16 years ago

I did test it.. However, I was stupid enough to make a svn diff of the wrong working copy (the one I used for experimenting; I wanted to have a clean copy for actually diff'ing the patch). I'm submitting the real patch now. Sorry about that. :\

by SF/dkasak13, 16 years ago

Attachment: dragon2.patch added

The real patch, against revision 39948

comment:3 by fingolfin, 16 years ago

Owner: set to sev-

comment:4 by sev-, 16 years ago

Status: newclosed

comment:5 by sev-, 16 years ago

So far, not bad. Feel free to use it as a start for your task.

Couple of notes: - consider use AD_ENTRY1(), or even better AD_ENTRY1s() in detection tables. - I would recommend to use engine name 'draci', not 'dragon', to be more faithful to the original - Do not enable this engine by default in configure - It is a really good that you consider using extended debug levels

comment:6 by sev-, 16 years ago

Also consider looking into patch #2725038 by another applicant this year. He've implemented some game data archive read code.

comment:7 by digitall, 6 years ago

Component: Engine: Draci
Game: Dragon History
Note: See TracTickets for help on using tickets.