#9003 closed patch
GSOC09: XMIDI parser switch cases
| Reported by: | SF/aasmith | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | low | Component: | Audio |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
Minor patch for GSoC, based off of trunk code. Have added several branches to one of the switch statements (on line 112), explicitly naming a bunch of XMIDI controllers that should be implemented down the line. This patch does not change any functionality, but just adds places in the code for future work.
Ticket imported from: #2758080. Ticket imported from: patches/1108.
Attachments (1)
Change History (8)
by , 16 years ago
| Attachment: | midiparser_xmidi.cpp added |
|---|
comment:1 by , 16 years ago
| Priority: | normal → low |
|---|
comment:2 by , 16 years ago
| Summary: | XMIDI parser switch cases → GSOC09: XMIDI parser switch cases |
|---|
comment:3 by , 16 years ago
Thank you for the submission. I notice it's not in diff/patch format. We will be reviewing this shortly.
comment:4 by , 16 years ago
Is this the format that is preferable?
144a145,152 > case 0x6e: // XMIDI_CONTROLLER_CHAN_LOCK > case 0x6f: // XMIDI_CONTROLLER_CHAN_LOCK_PROT > case 0x70: // XMIDI_CONTROLLER_VOICE_PROT > case 0x71: // XMIDI_CONTROLLER_TIMBRE_PROT > case 0x72: // XMIDI_CONTROLLER_BANK_CHANGE > case 0x73: // XMIDI_CONTROLLER_IND_CTRL_PREFIX > case 0x76: // XMIDI_CONTROLLER_CLEAR_BB_COUNT > case 0x78: // XMIDI_CONTROLLER_SEQ_BRANCH_INDEX
comment:5 by , 16 years ago
Thanks for your patch, I just added it to SVN.
Note that normally, patches should be generated in so-called "unified diff format" and attached to the tracker as a file.
comment:6 by , 16 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:7 by , 6 years ago
| Component: | → Audio |
|---|
sound/midiparser_xmidi.cpp that explicitly names new controllers