#9042 closed patch
SCI: resource-view-patch on SQ5/German fix
Reported by: | m-kiewitz | Owned by: | bluegr |
---|---|---|---|
Priority: | normal | Component: | Engine: SCI |
Version: | Keywords: | ||
Cc: | Game: | Space Quest 5 |
Description
Hi there,
I just implemented a quick fix so that SQ5/German doesn't bark about views being not there/invalid. It seems that patch loading is somewhat flawed, perhaps one should take a look at how SCI View does things.
Regards M. Kiewitz
Ticket imported from: #2819002. Ticket imported from: patches/1147.
Attachments (2)
Change History (7)
comment:1 by , 15 years ago
comment:2 by , 15 years ago
I just disassembled SCI View. There are several special cases, all occur when header size has bit 7 set. I have done 2 of them (80h and 81h), I don't fully understand the other coding, so that's why I'm leaving it. I hope someone finds a patch file that has that special case in it so ScummVM can support it as well.
ffs.: disassembly attached
comment:3 by , 15 years ago
Owner: | set to |
---|---|
Status: | new → closed |
comment:5 by , 6 years ago
Component: | → Engine: SCI |
---|---|
Game: | → Space Quest 5 |
Hm, this is a hack, and we should actually investigate what's the problem with patch loading. Leaving it open for now, until the real issue is sorted