#9065 closed patch
GMM: Enable loading & deleting of unnamed savegames
| Reported by: | SF/buddha_ | Owned by: | sev- |
|---|---|---|---|
| Priority: | normal | Component: | GUI |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
I added loading and deleting of unnamed savegames to the global main menu's load & save code.
Previously savegames that had no real description could not be loaded or deleted using GMM (This was because the filled gaps in the savegame list were confused with the really existing savegames that had empty descriptions).
It's just that sometimes some savegames happen to have no name and it'd still be nice to be able to load them (Happens easily e.g. with Cine if there's no description file as the savegames' descriptions are in it separate from the savegame files themselves).
I thought I'd better submit this as a patch so people more familiar the GMM/GUI part of ScummVM can review it first and commit it if ok. Thanks!
Ticket imported from: #2832247. Ticket imported from: patches/1170.
Attachments (3)
Change History (14)
by , 15 years ago
| Attachment: | gmm-load_del_empty.patch added |
|---|
comment:1 by , 15 years ago
Nice work :) So you've essentially replaced _list->getSelectedString().empty() with _saveList[selItem].getBool("is_dummy")
At a first glance, this patch seems to be ok, so unless someone has any objections, it looks good to be applied.
One question though: how can the user distinguish save games with no description from non-existent save games?
comment:2 by , 15 years ago
Good catch, silly issue. Sadly, I don't have time right now to look into this properly and try to reproduce the issue; so please forgive me if the following is not quite appropriate in detail, but I hope the general idea sounds OK.
Basically, what I'd like to see here is this: For savegames with empty description, display a string such as "Untitled savestate". And ideally, color it grey instead of black, to signify that this is not the real name.
This should then also be done in the save dialog, so that the user doesn't overwrite a state with empty description.
by , 15 years ago
| Attachment: | gmm-load_del_empty-v2.patch added |
|---|
Like first patch but with empty descriptions mapped to "Untitled savestate" (Made against trunk r43077, Unix style line endings)
by , 15 years ago
| Attachment: | gmm-load_del_empty-v2_alternative.patch added |
|---|
Alternative patch version with nothing but the mapping of empty descriptions to "Untitled savestate" (Made against trunk r43077, Unix style line endings)
comment:3 by , 15 years ago
Added two versions of the refined patch:
v2: Adds mapping of unnamed savegame names to "Untitled savestate".
v2_alternative: Does nothing else but map the unnamed savegame names to "Untitled savestate" (So does away with the "is_dummy"-checking). Thus an alternative approach.
P.S. I tried to figure out how to make the "Untitled savestate" texts grey in the SaveLoadChooser but couldn't really easily figure it out.
comment:4 by , 15 years ago
You can't have different colors in our list widget yet (apart from the selected entry).
comment:5 by , 15 years ago
I like the alternative version better, it's simple and it has the same results.
comment:6 by , 15 years ago
| Owner: | set to |
|---|
comment:9 by , 15 years ago
| Status: | new → closed |
|---|
comment:11 by , 6 years ago
| Component: | → GUI |
|---|
Patch for adding loading & deleting of unnamed savegames to GMM-load/save interface (Made against trunk r43054, Unix style line endings)