#9081 closed patch
AMIGAOS4: FS updated to new SDK
| Reported by: | raziel- | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Port: AmigaOS4 |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
I'm putting this diff up for revision. Please feel free to comment, it has been slightly polished and modified to fit the needs and changes of the new SDK for AmigaOS4. It has been tested and is working.
If i missed or abused some of the AcummVM coding or comment standards, please also feel free to correct me.
Thanks a lot
Ticket imported from: #2856708. Ticket imported from: patches/1186.
Attachments (1)
Change History (8)
comment:1 by , 15 years ago
comment:2 by , 15 years ago
I'm sorry, i was told to not clutter up the code and make it hard to read by putting an open { at the end of a line. I will of course revert that and upload a new diff
comment:3 by , 15 years ago
New diff uploaded, could you please check again and tell me what needs to be done?
Thanks a lot
comment:4 by , 15 years ago
Whoever told you that probably wasn't a member of the ScummVM team... ;). In any case, I think either formatting style is just fine, and I have used both on many occasions -- the only thing that I consider important is that inside a single project, you stay consistent.
comment:5 by , 15 years ago
D'oh, I had totally forgotten about this one :(. Applied to SVN now, thanks!
comment:6 by , 15 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:7 by , 6 years ago
| Component: | → Port: AmigaOS4 |
|---|
Actually, changes like this break our code formatting conventions: -AbstractFSNode *AmigaOSFilesystemFactory::makeRootFileNode() const { +AbstractFSNode *AmigaOSFilesystemFactory::makeRootFileNode() const +{