Opened 15 years ago

Closed 15 years ago

Last modified 6 years ago

#9118 closed patch (wontfix)

Patch to 1.0.0 configure script to support Cygwin

Reported by: SF/ewelsh42 Owned by: Kirben
Priority: normal Component: Port: Win32
Version: Keywords:
Cc: Game:

Description

I noticed that Cygwin support has been dropped from 1.0.0. I have attached a patch to the configure script to resupport it. Cygwin cross-compiling to MingW is pretty much just like MingW support, so I just copy/pasted the MingW portions and added the appropriate cygwin checks back in. The only things I added versus standard MingW support were the -mno-cygwin flags to tell it to compile against the MingW runtime (probably in more places than I needed, to just to be safe) and -I and -L flags for /usr/local, since standard Cygwin gcc usually ignores /usr/local when compiling.

This patch works fine for Cygwin, provided that the MingW development support has been installed (which, although not default, is a standard install option). Perhaps the new warning message in the configure script could be additionally changed to mention this? I do not know why Cygwin support was dropped, but I would like to recommend adding it back in, given that it is only a fairly minor extention to the existing MingW support.

Ticket imported from: #2905821. Ticket imported from: patches/1223.

Attachments (1)

configure_cygwin.diff (2.0 KB ) - added by SF/ewelsh42 15 years ago.
Patch to 1.0.0 configure script to support Cygwin

Download all attachments as: .zip

Change History (7)

by SF/ewelsh42, 15 years ago

Attachment: configure_cygwin.diff added

Patch to 1.0.0 configure script to support Cygwin

comment:1 by Kirben, 15 years ago

Owner: set to Kirben
Resolution: wontfix
Status: newclosed

comment:2 by Kirben, 15 years ago

Rejecting, Cygwin support was dropped for a specific reason. The '-mno-cygwin' option of Cygwin's GCC won't be around much longer.

comment:3 by lordhoto, 15 years ago

Owner: changed from Kirben to lordhoto

comment:4 by lordhoto, 15 years ago

It seems "-mno-cygwin" is a deprecated option, the commit message, which removed cygwin support says so too: r39757: "Drop Cygwin support, the -mno-cygwin option is been removed from GCC in the future.".

See also this thread on the cygwin mailing list: http://www.cygwin.com/ml/cygwin/2009-03/msg00766.html

That is IMHO enough reason to reject this patch, sorry for that. If you want to build a Win32 binary using a gcc, you should use MinGW.

comment:5 by lordhoto, 15 years ago

Owner: changed from lordhoto to Kirben

comment:6 by digitall, 6 years ago

Component: Port: Win32
Note: See TracTickets for help on using tickets.