#9302 closed patch (wontfix)
SCI: Do not fade rhythm channel
| Reported by: | tsoliman | Owned by: | bluegr |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCI |
| Version: | Keywords: | MIDI MT-32 | |
| Cc: | Game: | Quest for Glory 2 |
Description
There's a problem in QFG2's Shema dance sequence where the rhythm is being faded because of scene change. This drops the volume of rhythm channel down to zero causing the perception of missing notes. You can see the notes being played in the MT-32's LCD but the volume slowly drops to 0 and stays there. SSCI doesn't seem to fade rhythm.
Ticket imported from: #3266467. Ticket imported from: patches/1407.
Attachments (2)
Change History (8)
by , 14 years ago
| Attachment: | 0001-SCI-do-not-fade-rhythm-channel.patch added |
|---|
comment:1 by , 14 years ago
Looks good at a first glance :) Will check it over in the weekend
Quick change: use MIDI_RHYTHM_CHANNEL instead of 9 for the rhythm channel (defined in sci/sound/drivers/mididriver.h)
comment:2 by , 14 years ago
| Owner: | set to |
|---|
by , 14 years ago
| Attachment: | 0001-SCI-do-not-fade-rhythm-channel-revised-1.patch added |
|---|
revised patch after using MIDI_RHYTHM_CHANNEL as instructed by thebluegr
comment:4 by , 14 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
comment:5 by , 14 years ago
Thanks for your work, however I'm reluctant to add separate fade handling for the rhythm channel. I've applied an alternate fix in rev 9654068 (more information in the associated bug report).
Therefore, this patch is unfortunately rejected in this form, however it did help in pinpointing the actual bug
comment:6 by , 6 years ago
| Component: | → Engine: SCI |
|---|---|
| Game: | → Quest for Glory 2 |
| Keywords: | MIDI MT-32 added |
patch to skip channel 9 volume adjustment only if fading