#9482 closed patch
TOOLS: Allow building tools with Solaris Studio (w/ patch)
| Reported by: | SF/lblume | Owned by: | criezy |
|---|---|---|---|
| Priority: | normal | Component: | Tools |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
Tools are built using C++. On Solaris, I'm building them as part of OpenCSw, which at this time build wxwidgets with Solaris Studio. Since the C++ ABI are not compatible, this means I've got to build the tools with Solaris Studio C++ too. Attached are 3 simple patches for v1.6.0 that allow: - configure to pick up CC on Solaris - to work around a deque constructor not usable with CC - to fix the use of a wxT() macro that g++ allows, but not CC
Ticket imported from: #3614504. Ticket imported from: patches/1587.
Attachments (3)
Change History (15)
by , 11 years ago
| Attachment: | 0001-teach-configure-about-studio.patch added |
|---|
by , 11 years ago
| Attachment: | 0003-fix-wxT-macro-on-split-lines.patch added |
|---|
Patch to fix the use of wxT() on split lines
comment:1 by , 11 years ago
| Summary: | Allow building tools with Solaris Studio → TOOLS: Allow building tools with Solaris Studio |
|---|
comment:3 by , 11 years ago
| Summary: | TOOLS: Allow building tools with Solaris Studio → TOOLS: Allow building tools with Solaris Studio (w/ patch) |
|---|
comment:4 by , 11 years ago
The second patch looks strange to me: +// If using Solaris Studio +#if defined(__sun) && !defined(__GNUC__) + std::deque<std::string> arguments; for (int i = 1; i < argc; i++); +#else std::deque<std::string> arguments(argv, argv + argc); arguments.pop_front(); // Pop our own name +#endif
Didn't you mean to push_back argv[i] into deque in your for loop?
comment:5 by , 11 years ago
| Owner: | set to |
|---|
comment:6 by , 11 years ago
| Component: | Tools |
|---|---|
| Keywords: | build removed |
comment:7 by , 11 years ago
I pushed the first and third patches to master.
I also moved this tracker item to the patch tracker, where it belongs imho.
comment:8 by , 11 years ago
About patch 2: yes, I sure did mean that. I messed up somehow to integrate the patch properly in my build recipe after I had tested it. I'm going to rebuild and confirm, sorry about that.
by , 11 years ago
| Attachment: | 0002-avoid-deque-constructor-for-studio.patch added |
|---|
Patch to avoid a deque construction on Solaris when using CC (corrected)
comment:10 by , 11 years ago
| Status: | new → closed |
|---|
comment:12 by , 6 years ago
| Component: | → Tools |
|---|
Patch to allow configure to pick up Solaris Studio CC