SCI: Music volume at zero still plays music very softly

[csnover]

This can be seen in at least SQ6.

[waltervn]

IIRC, this is normal for the ealier games at least. Did you check SQ6 in dosbox?

[waltervn]

In SQ3 it does appear that in DOSBox the music actually stops playing if you set volume to 1 (though residual AdLib sounds can still be heard). In ScummVM it keeps playing.

Note: IIRC, the OPL2 velocity control only goes to "very quiet", there's no "off" setting, so you cannot go completely silent by controlling velocity alone.

In any case, I suggest we postpone working on these kinds of issues until the MIDI player has been rewritten. I have a lot of new driver code that has been collecting dust for years, pending this rewrite.

[csnover]

IIRC, this is normal for the ealier games at least. Did you check SQ6 in dosbox?

I thought I had, but no, you are right that the same behaviour of non-silent music at volume 0 does occur within SQ6. (Even for non-OPL music devices.) I feel like ScummVM ought to be able to have better control over this, but feel free to close this ticket if you don’t agree.

In any case, I suggest we postpone working on these kinds of issues until the MIDI player has been rewritten. I have a lot of new driver code that has been collecting dust for years, pending this rewrite.

Indeed, I know wjp had also mentioned pending work on rewriting the MIDI code, so this ticket is more of a reminder to check that this is no longer an issue once the rewrite is done, rather than a call to action to fix it in the current MIDI code.

[sev-]

MIDI driver for SCI has been rewritten since.