SCI: GK2: Gabriel Knight 2 GoG version with German Patch

[badungu]

Game: Gabriel Knight 2
Version: GOG-Version (with German Patch)
Language: German
Debug Output:
The game in 'Z:\ScummVM\Games\Gabriel Knight 2\' seems to be unknown.
Please, report the following data to the ScummVM team along with name
of the game you tried to add and its version, language, etc.:

{"resource.aud", 0, "3812e15c3a187f5b633bde3a4832b2cf", 167630831},
{"ressci.000", 0, "a19fc3604c6e5407abcf03d59ee87217", 169500205},
{"resmap.000", 0, "e6bab045e2b5eb205e150338e74d8641", 8092},
{"resmap.001", 0, "1b8bf6a23b37ed67358eb825fc687260", 2776},

German Patch Link: [deleted]

[csnover]

Thanks for your report! The linked “patch” is a complete copy of the entire game, and so is actually just a pirated release of the game. This release has been blacklisted in ScummVM per our usual piracy policy.

[Lebostein]

Same problem with the original german CD version. The game is not detected by ScummVM!

[digitall]

This has been reported again on the forums by Lebostein that this change blacklists the genuine German GK2 CD release. I have asked him there to add details here i.e. CD pressing ID, photo of CD and file md5sums so this can be resolved.

Link to forum post is ​https://forums.scummvm.org/viewtopic.php?p=97803

Relevant code is ​https://github.com/scummvm/scummvm/blob/master/engines/sci/detection_tables.h#L1138

[sluicebox]

GK2 is a six CD game. Because of that, there are six resource volume files. If instead you have *one really big one*... you don't have the real files.

There are fan tools that repackage resources this way. Excellent tools, but they're incompatible with ScummVM's approach of only supporting and detecting known original files / legitimate releases.

GOG's GK2 release is packaged this way, so we have a detection entry for that.

We routinely get invalid "new variant detected" tickets like this and I close them and say Go Get The Real Files. Unfortunately that's the nature of SCI files and detection. If I added a NEVER AGAIN detection entry for each, there would be a lot of junk.

I had already considered removing this entry. I have a stronger opinion now! It didn't even keep the same person from reporting it twice. This isn't a pirate release, it's something anyone can generate from their own files using popular tools. Someone just happened to upload theirs to a website once. Why build a monument to that?

But we don't need to think too hard about if a giant volume-zero file came from six 90's CDs. =)