SCI: Torin: Missing Multi-Language-CD detection of English, French

[ADeadTrousers]

hi!

Sorry for this is my first bug report on scummvm.

ScummVM version: 1.10.0git3248-ga403523faf (May 7 2017 12:57:54)

I have the pointsoft version of Torin's passage with english, french and german combined on one CD. Currently ScummVM does only detect the german version. My native language is german so it's not that big of a problem for me but I just wanted to point this out in case someone else has this version and is not german speaking.

Oh, and before I forget:
During "Add game" I get two message in the console about a not detected game (maybe the missing englich and french languages?)

-->
Das Spiel in "E:\Torin's Passage\" scheint noch unbekannt zu sein.
Bitte teilen Sie dem ScummVM-Team die folgenden Daten sowie den
Namen des Spiels, das Sie starten wollten, dessen Version, Sprache usw. mit:

{"data1.cab", 0, "42f7f89112a07c514b193a1a7fc0ffe1", 24189},

Das Spiel in "E:\Torin's Passage\" scheint noch unbekannt zu sein.
Bitte teilen Sie dem ScummVM-Team die folgenden Daten sowie den
Namen des Spiels, das Sie starten wollten, dessen Version, Sprache usw. mit:

{"data1.cab", 0, "42f7f89112a07c514b193a1a7fc0ffe1", 24189},

<--

If you need more information, for example the CD contents, just let me know.

wkr ADT

[ADeadTrousers]

Oh. I forgot to mention that the german language version is detected just fine and is working so far (I haven't played that much, but I will)

[csnover]

Thanks for your report! Could you please tell me the filesizes of your RESMAP.000 and RESSCI.000 files, so I can verify the matched game?

As far as those data1.cab files goes, I think that is ScummVM trying to detect an AGOS engine game, which is unfortunate (you can ignore it).

[csnover]

Actually, if you could just print out the entire directory structure of the disc here (dir /s on Windows, ls -lR on *nix), that would probably be a better idea. Thanks!

[ADeadTrousers]

Here you are:
[URL=​https://www.file-upload.net/download-12491176/list.txt.html]list.txt[/URL]
Sadly upload on Trac is not possible for me.

[ADeadTrousers]

Sorry:
​https://www.file-upload.net/download-12491176/list.txt.html

[csnover]

Could you please just paste the directory listing into a comment here, or at least use a pastebin site like gist.github.com? That site is super spammy and I’m not comfortable jumping through its hoops to download that file. Thanks!

[wjp]

As an aside, I'd also be very interested to know why uploading to trac here isn't working for you. Do you get any error messages?

[ADeadTrousers]

Oh. Sorry didn't noticed all the spam (I'm using noscript and adBlock)
Here is the list using gist
​https://gist.github.com/ADeadTrousers/011bbfba95b9cb56ebd715e262cf0322

Whenever I try to upload on Trac I get the following error:

Trac hat einen internen Fehler festgestellt:
IndexError: pop from empty list
Es ist ein interner Fehler aufgetreten. Bitte benachrichtigen Sie Ihren Trac-Administrator und fügen Sie eine Beschreibung an, wie der Fehler reproduziert werden kann.

Die Aktion, die den Fehler ausgelöst hat, war:

GET: /attachment/ticket/9776/

[csnover]

Thank you for the file listing! This helps narrow down what needs to be done in order to support this multi-language release.

Whenever I try to upload on Trac I get the following error:

For the moment, you may be able to work around this problem by going to your localisation preferences and setting the language to English (United States). If this works, I would appreciate it if you could attach save games to your other tickets. This problem with the bug tracker should be fixed properly soon, at which point you can go back to your native language.

[ADeadTrousers]

Now upload is working! Thanks.

[csnover]

Just a quick update on this issue.

From what I can tell, the advanced detector in ScummVM right now is not quite able to deal with the way Torin multilingual releases work, because the files that we must match to detect which localisations exist all have the same basename (e.g. 0.MSG), one per locale, and the detector cannot currently deal with more than one file in a game having the same basename.

I have opened ​PR#949 for improving the detector in a way that hopefully makes sense and lets us treat files in subdirectories with the same basename as distinct files. Once that lands, I have a patch ready to go for SCI engine that will fix the detection of localised Torin (except for Spanish and Italian, because I have not been able to track down an owner of these localisations yet to get usable signatures).

[csnover]

Thanks for your report! A fix for this issue has been added in commit d6ff67e3c465d4a2ab0ab24eb8d95dba6ec83091 and will be available in builds 1.10.0git-3446 and higher.

[ADeadTrousers]

Just a quick heads up on this:
Yes, now the different languages are being detected in the game selection screen. Although the voice-over is still in german, at least the menu and everything textual is in the selected language. I guess ~500KB of files per language subfolder is not enough to include the actual voice overs and 190MB on that AUD file is only enough for on language.
That's especially sad because I wanted to hear all the genuine Al Lowe jokes in their original form and not the bad german translations. When I first got the game I never bothered to try a different language but now that I'm older I also am wiser.

Nevertheless thanks for your effort. Keep up the good work.