Opened 6 years ago

Closed 4 years ago

#10947 closed defect (fixed)

SCUMM: MM (C64) - flashlight graphics aren't correct to original

Reported by: ATMcashpoint Owned by: sev-
Priority: normal Component: Engine: SCUMM
Version: Keywords: has-pull-request
Cc: Game: Maniac Mansion

Description

In a Commodore 64 emulator, the C64 version of Maniac Mansion handles turning on the flashlight in a dark room differently than in later versions.

The character sprites are partly lit up (looking different from either grayscale or normal brightness), and the area lit by the flashlight beam has different dimensions, with square corners instead of rounded corners.

Currently ScummVM (as of the April 25, 2019 Windows 64-bit daily build) keeps the character sprites in grayscale when the flashlight is on in a dark room, which is how the DOS V1 version handles it.

ScummVM also has a different shape to the lit area, which looks like the Night Vision effect from the cave maze in LOOM, and doesn't match either the DOS V1 or DOS V2 versions of Maniac.

To reproduce this bug: get the flashlight from the kitchen and some batteries (from the kitchen refrigerator or radio at the pool), put batteries into the flashlight, then go into a dark room and turn on the flashlight.

Game version: Maniac Mansion C64, English, running on Windows 10, build 1803, 64-bit.

Attachments (5)

maniac-c64.s67 (4.3 KB ) - added by ATMcashpoint 6 years ago.
mmc64flashlight1.png (5.6 KB ) - added by ATMcashpoint 6 years ago.
mmc64flashlightscummvm.png (9.1 KB ) - added by ATMcashpoint 6 years ago.
mmdosv1flashlight1.png (7.2 KB ) - added by ATMcashpoint 6 years ago.
mmdosv2flashlight1.png (6.5 KB ) - added by ATMcashpoint 6 years ago.

Download all attachments as: .zip

Change History (12)

by ATMcashpoint, 6 years ago

Attachment: maniac-c64.s67 added

by ATMcashpoint, 6 years ago

Attachment: mmc64flashlight1.png added

by ATMcashpoint, 6 years ago

Attachment: mmc64flashlightscummvm.png added

by ATMcashpoint, 6 years ago

Attachment: mmdosv1flashlight1.png added

by ATMcashpoint, 6 years ago

Attachment: mmdosv2flashlight1.png added

comment:1 by ATMcashpoint, 6 years ago

Type: enhancementdefect

comment:2 by ATMcashpoint, 6 years ago

Component: --Unset--Engine: SCUMM
Summary: Maniac Mansion C64: flashlight graphics aren't correct to originalMANIAC-C64: flashlight graphics aren't correct to original

comment:3 by segrax, 6 years ago

Owner: set to segrax

Can confirm, and am now working on a patch

comment:4 by digitall, 6 years ago

Keywords: has-pull-request added

comment:5 by Filippos Karapetis <bluegr@…>, 6 years ago

In 71172add:

SCUMM: Original V0-V2 flashlight shape and size for MM/Zak (#10947, #10951)

comment:6 by raziel-, 4 years ago

Summary: MANIAC-C64: flashlight graphics aren't correct to originalSCUMM: MM (C64) - flashlight graphics aren't correct to original

@bluegr

If i understand correctly the fix for this issue has been merged on May 5, 2019.

Can this be closed?

comment:7 by sev-, 4 years ago

Owner: changed from segrax to sev-
Resolution: fixed
Status: newclosed

This was implemented.

Note: See TracTickets for help on using tickets.