SCUMM: ZAK (C64) - flashlight graphics aren't correct to original

[ATMcashpoint]

Similar to the Maniac Mansion ticket I submitted earlier.

In the C64 version of Zak McKracken, when the flashlight is turned on in a dark room, the character sprites are partly lit up. The area lit up by the flashlight beam also has a different shape, with rectangular edges.

The DOS V1 & V2 versions instead turn the character sprites to normal brightness, and that's what ScummVM currently does.

The DOS V1 & V2 versions use two different flashlight beam designs as well, both with rounded edges. ScummVM's implementation is based on the DOS V2 version. Which means its handling of the DOS V1 flashlight beam is probably incorrect as well.

To reproduce this: unlock Melissa & Leslie; get into the Mars Hostel (using token from monolith & fuse from van to repair door); get the flashlight from the hostel locker; get into the Mars Face (using ladder from hostel & combination from African shaman in Kinshasa), unlock door to dark maze (using ladder, push crystal sphere next to door 1 in Great Chamber). As Melissa, enter the dark maze, then turn on the flashlight.

This is as of the April 25, 2019, daily build. Zak McKracken C64, English, running on Windows 10, build 1803, 64-bit.

[segrax]

Can confirm, and will work on this with #10947

[digitall]

​https://github.com/scummvm/scummvm/pull/1608

[Filippos Karapetis <bluegr@…>]

In 71172add:

SCUMM: Original V0-V2 flashlight shape and size for MM/Zak (#10947, #10951)

[raziel-]

@bluegr

If i understand correctly the fix for this issue has been merged on May 5, 2019.

Can this be closed?

[sev-]

This was implemented